Module: check_mk
Branch: master
Commit: 5139187c6eb265044ce4da95428caa7f3da556c4
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5139187c6eb265…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Wed Aug 17 18:22:40 2011 +0200
Updated bug entries
---
.bugs/206 | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/.bugs/206 b/.bugs/206
index 3bd3094..d6d5922 100644
--- a/.bugs/206
+++ b/.bugs/206
@@ -1,12 +1,17 @@
Title: View editor has layout problems in IE 8
Component: multisite
+State: done
+Class: bug
+Date: 2011-03-07 16:08:31
Benefit: 1
-State: open
Cost: 1
-Date: 2011-03-07 16:08:31
-Class: bug
+Fun: 0
For example the column editor: the input box is far too small.
Also the input boxes of title, etc. are too long.
Could someone try, if this is still the case?
+
+2011-08-17 18:22:33: changed state open -> done
+Added stylings for more equal layout in different browsers.
+Don't see any big styling differences now.
Module: check_mk
Branch: master
Commit: e276b354495053d52ea19a45c0705c46a47fe927
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e276b354495053…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Wed Aug 17 17:41:35 2011 +0200
Fixed changelog
---
ChangeLog | 38 +++++++++++++++++++++-----------------
1 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 2b4e501..f8260b9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -61,28 +61,32 @@
* Windows: inventory_services now allowes regexes, depends and state/start type
and also allows host tags.
- Multisite: * FIX: make non-Ascii characters in services names work again * FIX: Avoid
- exceptions in sidebar on Nagios restart * FIX: printer_supply perfometer: Using white font
- for black toners * FIX: ipmi: Skipping items with invalid data (0.000 val, "unspecified"
- unit) in summary mode
- * FIX: ipmi: Improved output formating in summary mode * FIX: BI - fixed wrong variable
- in running_on aggregation function * FIX: "view_name" variable missing error message when
- opening view.py
+ Multisite:
+ * FIX: make non-Ascii characters in services names work again
+ * FIX: Avoid exceptions in sidebar on Nagios restart
+ * FIX: printer_supply perfometer: Using white font for black toners
+ * FIX: ipmi: Skipping items with invalid data (0.000 val, "unspecified" unit) in summary mode
+ * FIX: ipmi: Improved output formating in summary mode
+ * FIX: BI - fixed wrong variable in running_on aggregation function
+ * FIX: "view_name" variable missing error message when opening view.py
while using the "BI Aggregation Groups" and "Hosts" snapins in sidebar
- * Introduced basic infrastructure for multilanguage support in Multisite * Make 'Views'
- snapin foldable * Replace old main view by dashboard. * Sidebar: Snapins can register for
- a triggered reload after a nagios
+ * Introduced basic infrastructure for multilanguage support in Multisite
+ * Make 'Views' snapin foldable
+ * Replace old main view by dashboard
+ * Sidebar: Snapins can register for a triggered reload after a nagios
restart has been detected. Check interval is 30 seconds for now.
- * Quicksearch snapin: Reloads host lists after a detected nagios restart. * New config
- directory multisite.d/ - similar to conf.d/ * great speed up of HTML rendering * support
- for Python profiling (set profile = True in multisite.mk, profile
+ * Quicksearch snapin: Reloads host lists after a detected nagios restart.
+ * New config directory multisite.d/ - similar to conf.d/
+ * great speed up of HTML rendering
+ * support for Python profiling (set profile = True in multisite.mk, profile
will be in var/check_mk/web)
* WATO: Added new hook "active-changes" which calls the registered hosts
with a dict of "dirty" hosts
- * Added column painter for host contacts * Added column painters for contact groups, added
- those to detail views * Added filters for host and service contact groups * Detail views
- of host/service now show contacts * Fix playing of sounds: All problem views now have
- play_sounds activated,
+ * Added column painter for host contacts
+ * Added column painters for contact groups, added those to detail views
+ * Added filters for host and service contact groups
+ * Detail views of host/service now show contacts
+ * Fix playing of sounds: All problem views now have play_sounds activated,
all other deactivated.
* Rescheduling of Check_MK: introduce a short sleep of 0.7 sec. This increases
the chance of the passive services being updated before the repaint.
Module: check_mk
Branch: master
Commit: 9d89383e6d5998e291ab18e65e7d17271a715ec6
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9d89383e6d5998…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Wed Aug 17 14:25:28 2011 +0200
Remove leading/trailing spaces from service description
---
ChangeLog | 2 ++
modules/check_mk.py | 11 ++++++++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 2b4e501..6973784 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,8 @@
1.1.11i2:
Core, Setup, etc.:
* FIX: sort output of cmk --list-hosts alphabetically
+ * FIX: automatically remove leading and trailing space from service names
+ (this fixes a problem with printer_pages and an empty item)
* Great speed up of cmk -N/-C/-U/-R, especially when number of hosts is
large.
* new main.mk option delay_precompile: if True, check_mk will skip Python
diff --git a/modules/check_mk.py b/modules/check_mk.py
index cacaede..b0af17b 100755
--- a/modules/check_mk.py
+++ b/modules/check_mk.py
@@ -1012,18 +1012,23 @@ def service_description(checkname, item):
if not descr_format:
descr_format = check_info[checkname][1]
+ # Note: we strip the service description (remove spaces).
+ # One check defines "Pages %s" as a desription, but the item
+ # can by empty in some cases. Nagios silently drops leading
+ # and trailing spaces in the configuration file.
+
if type(item) == str:
# Remove characters from item name that are banned by Nagios
item_safe = "".join([ c for c in item if c not in nagios_illegal_chars ])
if "%s" not in descr_format:
descr_format += " %s"
- return descr_format % (item_safe,)
+ return (descr_format % (item_safe,)).strip()
if type(item) == int or type(item) == long:
if "%s" not in descr_format:
descr_format += " %s"
- return descr_format % (item,)
+ return (descr_format % (item,)).strip()
else:
- return descr_format
+ return descr_format.strip()
# +----------------------------------------------------------------------+
# | ____ __ _ _ _ |