Checkmk git commits March 2011

checkmk-commits@lists.checkmk.com

3 participants
205 discussions

Check_MK Git: check_mk: if/if64: output speed correctly

by mk＠mathias-kettner.de

Module: check_mk Branch: master Commit: 53c0805062a0991fe2ba5302147d0bfa19fdd48a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=53c0805062a099… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 2 10:18:01 2011 +0100 if/if64: output speed correctly --- ChangeLog | 1 + modules/check_mk_base.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 0fe0819..12b5622 100644 --- a/ChangeLog +++ b/ChangeLog @@ -12,6 +12,7 @@ This is still experimental! Checks & Agents: + * FIX: if/if64: output speed correctly (1.50MB/s instead of 1MB/s) * FIX: drbd now handles output of older version without an ep field * FIX: repaired df_netapp32 * FIX: Added SNMP scan function of df_netapp and df_netapp32 diff --git a/modules/check_mk_base.py b/modules/check_mk_base.py index e012d92..8685fb0 100755 --- a/modules/check_mk_base.py +++ b/modules/check_mk_base.py @@ -1027,9 +1027,9 @@ def get_nic_speed_human_readable(speed): elif speedi == 1000000000: speed = "1GBit/s" elif speed < 1500000000: - speed = "%dMBit/s" % (speedi / 1000000) + speed = "%.2fMBit/s" % (speedi / 1000000.0) else: - speed = "%dGBit/s" % (speedi / 1000000000) + speed = "%.2fGBit/s" % (speedi / 1000000000.0) except: pass return speed

13 years, 4 months

Check_MK Git: check_mk: Cleaned up ChangeLog

by mk＠mathias-kettner.de

Module: check_mk Branch: master Commit: 95e8d0930abd66c3ef9035ed6c09e4814273039a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=95e8d0930abd66… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 2 10:12:08 2011 +0100 Cleaned up ChangeLog --- ChangeLog | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3fc1bbb..0fe0819 100644 --- a/ChangeLog +++ b/ChangeLog @@ -4,19 +4,17 @@ they are not SNMP hosts. * FIX: precompile: make sure check includes are added before actual checks + * FIX: setup.sh: do not prepend current directory to url_prefix + * FIX: output agent version also for mixed (tcp|snmp) hosts * RPM: use BuildArch: noarch in spec file rather than as a command line option (thanks to Ulrich Kiermayr) - * FIX: setup.sh: do not prepend current directory to url_prefix * setup.sh: Allow to install Check_MK into existing OMD site (>= 0.46). This is still experimental! - * FIX: output agent version also for mixed (tcp|snmp) hosts Checks & Agents: * FIX: drbd now handles output of older version without an ep field - * systemtime: new simple check for time synchronization on Windows - (needs agent update) * FIX: repaired df_netapp32 - * Added SNMP scan function of df_netapp and df_netapp32 + * FIX: Added SNMP scan function of df_netapp and df_netapp32 * FIX: repaired apc_symmetra (was broken due to new option -Ot for SNMP) * FIX: df, hr_fs and other filesystem checks: fix bug if using @@ -28,10 +26,8 @@ * FIX: df_netapp/32: fixed output of used percentage (was always 0% due to integer division) * FIX: fixed manual of df (magic_norm -> magic_normsize) - * Added Perf-O-Meter for non-df filesystem checks (e.g. netapp) * FIX: removed filesystem_trend_perfdata. It didn't work. Use now df-parameter "trend_perfdata" (see new man page of df) - * hp_proliant_*: improve scan function (now just looks for "proliant") * FIX: cisco_temp_perf: fix return state in case of WARNING (was 0 = OK) * FIX: repair PNP template for df when using trends * FIX: cisco_qos: fix WATO exception (was due to print command in check) @@ -41,6 +37,10 @@ * FIX: netapp_volumes: Fixed snmp scan function * FIX: blade_*: Fixed snmp scan function * FIX: nfsmount: fix exception in check in case of 'hanging' + * systemtime: new simple check for time synchronization on Windows + (needs agent update) + * Added Perf-O-Meter for non-df filesystem checks (e.g. netapp) + * hp_proliant_*: improve scan function (now just looks for "proliant") Multisite: * FIX: fix json/python Webservice

13 years, 4 months

Check_MK Git: check_mk: output agent version also for mixed hosts

by mk＠mathias-kettner.de

Module: check_mk Branch: master Commit: 3eaa52636bf6868fff702354682f6b0a3f4ebf0d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3eaa52636bf686… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 2 10:11:17 2011 +0100 output agent version also for mixed hosts --- ChangeLog | 1 + modules/check_mk_base.py | 6 ++---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index bb8ed69..3fc1bbb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -9,6 +9,7 @@ * FIX: setup.sh: do not prepend current directory to url_prefix * setup.sh: Allow to install Check_MK into existing OMD site (>= 0.46). This is still experimental! + * FIX: output agent version also for mixed (tcp|snmp) hosts Checks & Agents: * FIX: drbd now handles output of older version without an ep field diff --git a/modules/check_mk_base.py b/modules/check_mk_base.py index 85ed85f..e012d92 100755 --- a/modules/check_mk_base.py +++ b/modules/check_mk_base.py @@ -743,6 +743,7 @@ def do_all_checks_on_host(hostname, ipaddress): num_errors = 0 check_table = get_sorted_check_table(hostname) problems = [] + for checkname, item, params, description, info in check_table: # In case of a precompiled check table info is the aggrated # service name. In the non-precompiled version there are the dependencies @@ -819,11 +820,8 @@ def do_all_checks_on_host(hostname, ipaddress): submit_aggregated_results(hostname) try: - if not is_snmp_host(hostname): + if is_tcp_host(hostname): version_info = get_host_info(hostname, ipaddress, 'check_mk') - # TODO: remove this later, when all agents have been converted - if not version_info: - version_info = get_host_info(hostname, ipaddress, 'mknagios') agent_version = version_info[0][1] else: agent_version = "(unknown)"

13 years, 4 months

Check_MK Git: check_mk: Updated bug entries

by mk＠mathias-kettner.de

Module: check_mk Branch: master Commit: 48ee9be6e32fadc3653918e4203f58b311e8ab69 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=48ee9be6e32fad… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 2 10:02:40 2011 +0100 Updated bug entries --- .bugs/169 | 28 ++++++++++++++++++++++++++++ 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/.bugs/169 b/.bugs/169 new file mode 100644 index 0000000..14a2eed --- /dev/null +++ b/.bugs/169 @@ -0,0 +1,28 @@ +Title: WATO misses services +Component: wato +Benefit: 4 +State: open +Cost: 2 +Date: 2011-03-02 09:45:16 +Class: bug + +In some strange cases WATO seems to loose services: + +> I’m having a problem where services added via WATO will just disappear if +> you run check_mk –O. +> +> Today I added a new group of some 5 devices, via WATO. I selected some +> (snmp) services – various ports and interfaces. Several were auto added +> – temperature, fans, etc. +> +> I then activated the configuration, again via WATO. Then checked the hosts, +> and all services were there and polling. Everything was good. +> +> Later I edited some (completely unrelated) hosts via the files in +> etc/check_mk/conf.d and ran check_mk to activate my changes. I noticed that I +> lost about 100 services from my totals when the new configuration activated. +> A check showed that my new hosts (and several older ones, too) has lost all +> of their services – including the automatic ones! The only remaining +> services were legacy services that I had much earlier added (globally) +> via editing files. +

13 years, 4 months

Check_MK Git: check_mk: nfsmount: fix exception in check in case of hanging

by mk＠mathias-kettner.de

Module: check_mk Branch: master Commit: 93222da1126f53abc8e76356a70e6c8128cd82f9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=93222da1126f53… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Mar 2 09:25:20 2011 +0100 nfsmount: fix exception in check in case of hanging --- ChangeLog | 1 + checks/nfsmounts | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 19b03ae..bb8ed69 100644 --- a/ChangeLog +++ b/ChangeLog @@ -39,6 +39,7 @@ * FIX: netapp_volumes: The check handled 64-bit aggregates correctly * FIX: netapp_volumes: Fixed snmp scan function * FIX: blade_*: Fixed snmp scan function + * FIX: nfsmount: fix exception in check in case of 'hanging' Multisite: * FIX: fix json/python Webservice diff --git a/checks/nfsmounts b/checks/nfsmounts index ed73e04..e422146 100644 --- a/checks/nfsmounts +++ b/checks/nfsmounts @@ -39,12 +39,12 @@ def check_nfsmounts(item, params, info): if size_blocks < 0 or free_blocks < 0 or blocksize > 1024*1024: return (1, "WARNING - Stale NFS handle") - gb = 1024 * 1024 * 1024.0 - size_gb = (size_blocks * blocksize) / gb - free_gb = (free_blocks * blocksize) / gb - used_gb = size_gb - free_gb - used_perc = 100.0 * used_gb / size_gb if line[1] == 'ok': + gb = 1024 * 1024 * 1024.0 + size_gb = (size_blocks * blocksize) / gb + free_gb = (free_blocks * blocksize) / gb + used_gb = size_gb - free_gb + used_perc = 100.0 * used_gb / size_gb return (0, "OK - %.1f%% used (%.1f of %.1f GB)" % (used_perc, used_gb, size_gb)) else: return (2, "CRITICAL - server not responding")

13 years, 4 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: a390c871ed47b1eb4bd9e1ce77ebc4f8ad1816b4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a390c871ed47b1… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Mar 1 18:40:54 2011 +0100 Updated bug entries --- .bugs/168 | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/.bugs/168 b/.bugs/168 new file mode 100644 index 0000000..32c2c77 --- /dev/null +++ b/.bugs/168 @@ -0,0 +1,18 @@ +Title: ORACLE agent: mounted (readonly) databases make problems +Component: checks +Benefit: 1 +State: open +Cost: 2 +Date: 2011-03-01 18:39:44 +Class: feature + +> Our organisation has one live and one synchronised copy of each instance +> distributed over two Oracle servers. The copy instances are "MOUNTED" but not +> "OPEN", which causes an error with the Oracle plugin: +> +> instance1 /oracledata/instance1/data/welfare_clob.dbf WELFARE_CLOB AVAILABLE YES 44032 131072 44024 1 ONLINE 8192 ONLINE +> instance1 /oracledata/instance1/data/welfare_live.dbf WELFARE_LIVE AVAILABLE YES 64000 131072 63992 1 ONLINE 8192 ONLINE +> instance2 select f.file_name, f.tablespace_name, f.status, f.AUTOEXTENSIBLE, f.blocks, f.maxblocks, f.USER_BLOCKS, f.INCREMENT_BY, f.ONLINE_STATUS, t.BLOCK_SIZE, t.status from dba_data_files f, dba_tablespaces t where f.tablespace_name = t.tablespace_name +> instance2 * +> instance2 ERROR at line 1: +> instance2 ORA-01219: database not open: queries allowed on fixed tables/views only

13 years, 4 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 10f9d405d4c335e4b59c71e4f4a79e4c2e82d9b3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=10f9d405d4c335… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Mar 1 18:36:18 2011 +0100 Updated bug entries --- .bugs/167 | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/.bugs/167 b/.bugs/167 new file mode 100644 index 0000000..38f0d05 --- /dev/null +++ b/.bugs/167 @@ -0,0 +1,10 @@ +Title: Update Livestatus API for Python +Component: livestatus +Benefit: 1 +State: open +Cost: 1 +Date: 2011-03-01 18:35:46 +Class: cleanup + +Take the API from web/htdocs/livestatus.py, rework the examples, +make it work.

13 years, 4 months

Check_MK Git: check_mk: Improved output colors of cmk -I

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: e6e6ca279abcb1fd3492b6002eb40e4fcb852f23 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e6e6ca279abcb1… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Mar 1 18:30:33 2011 +0100 Improved output colors of cmk -I --- modules/check_mk.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/check_mk.py b/modules/check_mk.py index 51ececb..266ce5b 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -1788,7 +1788,7 @@ def make_inventory(checkname, hostnamelist, check_only=False, include_state=Fals if not os.path.exists(autochecksdir): os.makedirs(autochecksdir) file(filename, "w").write('# %s\n[\n%s]\n' % (filename, ''.join(newchecks))) - sys.stdout.write('%-30s ' % (tty_blue + checkname + tty_normal)) + sys.stdout.write('%-30s ' % (tty_cyan + tty_bold + checkname + tty_normal)) sys.stdout.write('%s%d new checks%s\n' % (tty_bold + tty_green, count_new, tty_normal)) return newitems

13 years, 4 months

Check_MK Git: check_mk: Updated bugs

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: b1e6586522e8f371fd1e24849d24bf2af560f1ca URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b1e6586522e8f3… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Mar 1 18:30:21 2011 +0100 Updated bugs --- .bugs/166 | 29 +++++++++++++++++++++++++++++ 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/.bugs/166 b/.bugs/166 new file mode 100644 index 0000000..5f9226c --- /dev/null +++ b/.bugs/166 @@ -0,0 +1,29 @@ +Title: legacy_checks could allow passive services +Component: core +Benefit: 1 +State: open +Cost: 2 +Date: 2011-03-01 18:24:00 +Class: feature + +Chris Bowlby: +> I'm not sure if anyone has mentioned this before, based on a cursory +> search of the mailing list, but would be nice to have an optional +> element that can be used as part of the legacy_check param that would +> denote that particular service as being passive. For example: +> +> legacy_checks += [ +> ( ( "passive_check_command", "PASSIVE SERVCE", False, True), ALL_HOSTS), +> ( ( "active_check_command", "ACTIVE SERVCE", False), ALL_HOSTS), +> ( ( "active_check_command", "ACTIVE SERVCE2", False, False), ALL_HOSTS), +> .... +> ] +> +> The example would set the first legacy check as passive, and the other +> two as active. I know that one can simply use the extra_nagios_conf +> parameter, but it's a wee bit clunky if you've got a large number of +> passive checks and other elements that need to be converted. This idea +> may provide a cleaner method where one can simply define the passive +> check here, and allow them to take advantage of the other elements, such +> as service groups, contact group links, etc. It also reduces the changes +> of miss-creating an entry that causes a conflict later on.

13 years, 4 months

Check_MK Git: check_mk: cisco_qos: remove print, that broke WATO

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 67dc7f70b7ed9779814d0e3ab5d6df53676ef127 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=67dc7f70b7ed97… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Mar 1 11:13:50 2011 +0100 cisco_qos: remove print, that broke WATO --- ChangeLog | 1 + README.writing_checks | 6 ++++++ checks/cisco_qos | 2 -- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 06a904e..7ccea6a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -33,6 +33,7 @@ * hp_proliant_*: improve scan function (now just looks for "proliant") * FIX: cisco_temp_perf: fix return state in case of WARNING (was 0 = OK) * FIX: repair PNP template for df when using trends + * FIX: cisco_qos: fix WATO exception (was due to print command in check) Multisite: * FIX: fix json/python Webservice diff --git a/README.writing_checks b/README.writing_checks index b473704..6aeb27b 100644 --- a/README.writing_checks +++ b/README.writing_checks @@ -143,6 +143,12 @@ SNMP based checks: * Only use numeric OIDs in your checks. Name based OIDs rely on MIB files and the check won't work when the MIB files are not in place. +Forbidden things: +* Neither the check- nor the inventory function may use the print command + or otherwise output any data to stdout or stderr nor otherwise communicate + with the outside. An rare exception to this are checks that need a dedicated + data storage (such as logwatch: it keeps unread log messages in files). + Manpages * Each check *must* have a man page. This should be: diff --git a/checks/cisco_qos b/checks/cisco_qos index 1a6e6cc..20a46ac 100644 --- a/checks/cisco_qos +++ b/checks/cisco_qos @@ -193,8 +193,6 @@ def check_cisco_qos(item, params, info): perfdata.append( (name, rate, warn, crit, min, max) ) except MKCounterWrapped, e: wrapped = True - # continue, other counters might wrap as well - print e # if at least one counter wrapped, we do not handle the counters at all if wrapped:

13 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits March 2011