Module: check_mk
Branch: master
Commit: 64e29ea9d67cb0beef5404837181e36a72322aeb
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=64e29ea9d67cb0…
Author: Andreas Boesl <ab(a)mathias-kettner.de>
Date: Mon Apr 28 16:30:11 2014 +0200
FIX Table checkboxes: Fixed bug where selected checkboxes got ignored
Sometimes not all selected lines of a multisite table where actually processed.
This happened especially often when the monitoring server had a high disk I/O.
---
.werks/909 | 9 +++++++++
ChangeLog | 1 +
web/htdocs/weblib.py | 4 ++--
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/.werks/909 b/.werks/909
new file mode 100644
index 0000000..fdb2036
--- /dev/null
+++ b/.werks/909
@@ -0,0 +1,9 @@
+Title: Table checkboxes: Fixed bug where selected checkboxes got ignored
+Level: 1
+Component: multisite
+Version: 1.2.5i3
+Date: 1398694950
+Class: fix
+
+Sometimes not all selected lines of a multisite table where actually processed.
+This happened especially often when the monitoring server had a high disk I/O.
diff --git a/ChangeLog b/ChangeLog
index e4b6a1e..8061e53 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -63,6 +63,7 @@
* 0887 Add new column painter "Host Notifications Enabled"...
* 0905 FIX: Multisite context buttons: links in context buttons are no longer called
twice...
* 0906 FIX: Improved transaction handling in Web GUI...
+ * 0909 FIX: Table checkboxes: Fixed bug where selected checkboxes got ignored...
WATO:
* 0784 Improved security of WATO bulk inventory by using transaction ids
diff --git a/web/htdocs/weblib.py b/web/htdocs/weblib.py
index 0123f58..f3c6022 100644
--- a/web/htdocs/weblib.py
+++ b/web/htdocs/weblib.py
@@ -85,7 +85,7 @@ def get_rowselection(ident):
return vo.get(ident, [])
def set_rowselection(ident, rows, action):
- vo = config.load_user_file("rowselection/%s" % selection_id(), {})
+ vo = config.load_user_file("rowselection/%s" % selection_id(), {}, True)
if action == 'set':
vo[ident] = rows
@@ -102,7 +102,7 @@ def set_rowselection(ident, rows, action):
if not os.path.exists(config.user_confdir + '/rowselection'):
make_nagios_directory(config.user_confdir + '/rowselection')
- config.save_user_file("rowselection/%s" % selection_id(), vo)
+ config.save_user_file("rowselection/%s" % selection_id(), vo, True)
def ajax_set_rowselection():
ident = html.var('id')