Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4d43accdaa4319a106f4662e4b65e30fc0f049d4 https://github.com/tribe29/checkmk/commit/4d43accdaa4319a106f4662e4b65e30fc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-30 (Fri, 30 Oct 2020) Changed paths: M cmk/gui/wato/page_handler.py Log Message: ----------- Add some comment Change-Id: Ice9fe9d5cfbf1000805eeee1894e85bd7c65b2c8 Commit: 3694afbf256aed2ae8eb7a2fd6087eea8f53615c https://github.com/tribe29/checkmk/commit/3694afbf256aed2ae8eb7a2fd6087eea8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-30 (Fri, 30 Oct 2020) Changed paths: M cmk/gui/backup.py M cmk/gui/gui_background_job.py M cmk/gui/key_mgmt.py M cmk/gui/plugins/wato/background_job.py M cmk/gui/plugins/wato/bi_config.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/plugins/wato/utils/base_modes.py M cmk/gui/plugins/wato/utils/simple_modes.py M cmk/gui/wato/mkeventd.py M cmk/gui/wato/page_handler.py M cmk/gui/wato/pages/activate_changes.py M cmk/gui/wato/pages/analyze_configuration.py M cmk/gui/wato/pages/audit_log.py M cmk/gui/wato/pages/bulk_discovery.py M cmk/gui/wato/pages/bulk_edit.py M cmk/gui/wato/pages/custom_attributes.py M cmk/gui/wato/pages/diagnostics.py M cmk/gui/wato/pages/folders.py M cmk/gui/wato/pages/global_settings.py M cmk/gui/wato/pages/host_rename.py M cmk/gui/wato/pages/hosts.py M cmk/gui/wato/pages/ldap.py M cmk/gui/wato/pages/notifications.py M cmk/gui/wato/pages/parentscan.py M cmk/gui/wato/pages/random_hosts.py M cmk/gui/wato/pages/read_only.py M cmk/gui/wato/pages/roles.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/search.py M cmk/gui/wato/pages/sites.py M cmk/gui/wato/pages/tags.py M cmk/gui/wato/pages/timeperiods.py M cmk/gui/wato/pages/users.py Log Message: ----------- Add ActionResult type hint to all WatoMode action methods Change-Id: I78b378b32e6601b660e6752fe252ab39c0de8321 Commit: 96411528904e8c9651f335818a3e7ca34aed68d1 https://github.com/tribe29/checkmk/commit/96411528904e8c9651f335818a3e7ca34… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-30 (Fri, 30 Oct 2020) Changed paths: M cmk/gui/wsgi/applications/checkmk.py Log Message: ----------- Add type hints to checkmk WSGI app And fix some real errors uncovered by these type hints. Change-Id: Id8356e5f95c21b6fd869979f38c9ffc3fd085635 Commit: 78b8268f27d5b622026f437ad5a8c62b98fa2e5e https://github.com/tribe29/checkmk/commit/78b8268f27d5b622026f437ad5a8c62b9… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-30 (Fri, 30 Oct 2020) Changed paths: M cmk/gui/backup.py M cmk/gui/key_mgmt.py M cmk/gui/plugins/wato/utils/base_modes.py M cmk/gui/plugins/wato/utils/simple_modes.py M cmk/gui/wato/page_handler.py M cmk/gui/wato/pages/activate_changes.py M cmk/gui/wato/pages/audit_log.py M cmk/gui/wato/pages/sites.py M cmk/gui/wsgi/applications/checkmk.py Log Message: ----------- Clarify WATO action result type Instead of returning False to abort the page processing after the action call, we now return a FinalizeRequest object to trigger this behaviour, which is easier to understand without knowing the details of the WATO page handler. Change-Id: I4f9841ff57f6ae6c511e22babc65d9cdf59f3258 Commit: e7de2ed05c694830cc3a7ff78d66d17e6830f74a https://github.com/tribe29/checkmk/commit/e7de2ed05c694830cc3a7ff78d66d17e6… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-30 (Fri, 30 Oct 2020) Changed paths: M tests/unit/cmk/gui/test_userdb.py Log Message: ----------- Add some tests for load_custom_attr Change-Id: Id3b65ff1efb49bda5cfd3c3c11dd10abb3d5b982 Commit: 9309a472dd0cc550bd3427e4b2d6d5183093da39 https://github.com/tribe29/checkmk/commit/9309a472dd0cc550bd3427e4b2d6d5183… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-30 (Fri, 30 Oct 2020) Changed paths: M cmk/gui/userdb.py M tests/unit/cmk/gui/test_userdb.py Log Message: ----------- Add missing locking to users session store Between loading and saving of the stored sessions, the GUI has to hold a lock on the file to prevent user sessions from overwriting each others information. Change-Id: Ic7380348d776ce6e18956e47dd829b5ab6d562e6 Commit: 96dfb8356db25e9b9b32270f5c962d38f0c91cfa https://github.com/tribe29/checkmk/commit/96dfb8356db25e9b9b32270f5c962d38f… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-30 (Fri, 30 Oct 2020) Changed paths: M cmk/gui/login.py M cmk/gui/wsgi/applications/checkmk.py M tests/unit/cmk/gui/test_login_unit.py Log Message: ----------- Refactor login.authenticate to context manager The login.authenticate method is now calling config.clear_user_login() just like e.g. the WSGI authentication does to clearly mark the end of the current user login. Change-Id: Ibb50f66e8a4020475143788e309ef28507c91ea1 Compare: https://github.com/tribe29/checkmk/compare/afd33ec4d26e...96dfb8356db2