Module: check_mk
Branch: master
Commit: bf30fc66222ef1d9889712df21d19e0b22e4f741
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bf30fc66222ef1…
Author: Andreas Boesl <ab(a)mathias-kettner.de>
Date: Wed Jun 25 15:26:46 2014 +0200
FIX if.include: fixed incorrect traffic percentage values in the check output of if
checks
There was a display bug in the traffic percentages. The value was off by factor
8.<br>
This bug didn't cause wrong check results or performance data values, just a visual
glitch.
---
.werks/943 | 10 ++++++++++
ChangeLog | 1 +
checks/if.include | 2 +-
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/.werks/943 b/.werks/943
new file mode 100644
index 0000000..3f9f618
--- /dev/null
+++ b/.werks/943
@@ -0,0 +1,10 @@
+Title: if.include: fixed incorrect traffic percentage values in the check output of if
checks
+Level: 2
+Component: checks
+Class: fix
+State: unknown
+Version: 1.2.5i5
+Date: 1403702453
+
+There was a display bug in the traffic percentages. The value was off by factor
8.<br>
+This bug didn't cause wrong check results or performance data values, just a visual
glitch.
diff --git a/ChangeLog b/ChangeLog
index 2db9072..52ba5bc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,7 @@
Checks & Agents:
* 0994 FIX: agent plugin smart: fixed syntax error
* 0989 FIX: logwatch.ec: Fix forwarding multiple messages via syslog/TCP...
+ * 0943 FIX: if.include: fixed incorrect traffic percentage values in the check output
of if checks...
WATO:
* 0990 FIX: Fix HTTP error handling in bulk inventory...
diff --git a/checks/if.include b/checks/if.include
index dec76cd..9dc90b0 100644
--- a/checks/if.include
+++ b/checks/if.include
@@ -570,7 +570,7 @@ def check_if_common_single(item, params, info, force_counter_wrap =
False, has_n
infotext += ", %s: %s" % (what, format_value(traffic))
if speed:
- perc_used = 100.0 * traffic / speed
+ perc_used = 100.0 * traffic / (speed / 8)
assumed_info = ""
if assumed_speed_in or assumed_speed_out: