Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: ec88c8f4682bf672b02f20eb26e49396c5336ade https://github.com/tribe29/checkmk/commit/ec88c8f4682bf672b02f20eb26e49396c… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M cmk/fetchers/snmp_backend/stored_walk.py Log Message: ----------- Fix typo Change-Id: I25c1c7daabe50f904125857208ef3cd795886e8c Commit: b59762dc2cba4595a6bbfe01d26f4fffc0dd97ae https://github.com/tribe29/checkmk/commit/b59762dc2cba4595a6bbfe01d26f4fffc… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M cmk/fetchers/snmp_backend/stored_walk.py M cmk/snmplib/snmp_cache.py M tests/testlib/snmp.py Log Message: ----------- snmpwalk: Fixup typing The users obviously do not want to modify cached data on the fly. Let's make the structure immutable. CMK-12721 Change-Id: I44341def01bbf4a6b0d01ab3a02bd979ec6f9da0 Commit: 1769cf24caccd1284724d1eb23f2b70c0bf478bf https://github.com/tribe29/checkmk/commit/1769cf24caccd1284724d1eb23f2b70c0… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M cmk/fetchers/snmp_backend/stored_walk.py M cmk/snmplib/snmp_cache.py Log Message: ----------- snmpwalk: Remove useless cache The host cache wouldn't even cache the result of a calculation but only some local disk I/O. However, local disk I/O will always be at least as fast as the *real* SNMP traffic it's faking. As such, it is but gratuitous obfuscation. Don't cache the cache! CMK-12721 Change-Id: Ifd76b122d1cbf52327137f4e3449e00f1cd8acf1 Commit: b31862599e4740e4f9d1c5a6f22ed95b6b57156f https://github.com/tribe29/checkmk/commit/b31862599e4740e4f9d1c5a6f22ed95b6… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M cmk/base/agent_based/confcheckers.py M cmk/base/automations/check_mk.py M cmk/base/config.py M cmk/base/dump_host.py M cmk/base/modes/check_mk.py M cmk/base/sources.py M tests/unit/cmk/base/sources/test_data_sources.py Log Message: ----------- Revert "Check for stored walks with simulation mode" If simulation is set, the data is always obtained from the FileCache and never from the Fetcher. However, simulation of SNMP plugs a StoredWalkSNMPBackend into the Fetcher (although it really *is* a cache). So, in that very case, we actually want to skip the FileCache and obtain the cached data *from the fetcher*! Not all simulation modes are born equal. CMK-12721 This reverts commit 5caa902a32dde84499dc4739394875a02451ac39. Change-Id: Ie5f3ff3479351276f1af61a671733e22c73be588 Commit: 5fd74a8c2782b48eb5288372df24c265ce43a003 https://github.com/tribe29/checkmk/commit/5fd74a8c2782b48eb5288372df24c265c… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M cmk/fetchers/_snmp.py Log Message: ----------- Inline trivial call and avoid double negatives Just trying to make sense of the extra layer of caching in the SNMP fetcher. 🤦 CMK-12721 Change-Id: I164a6666f0570322cd3b38f18ec512f17902fc8f Commit: 95860fcb0a90a125f62d11ee3fb35ef219c16cfa https://github.com/tribe29/checkmk/commit/95860fcb0a90a125f62d11ee3fb35ef21… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M cmk/fetchers/snmp_backend/stored_walk.py Log Message: ----------- StoredWalk backend: Make path an instance variable The "backend" reads stored data from a file. So having a Path attribute satisfies the Principle of Least Surprise. CMK-12721 Change-Id: Icca53673ad0c0b101bca4470c077e2d3c3113f75 Commit: e431098c21afcc0ee791b9d7655ae0a1e10641f4 https://github.com/tribe29/checkmk/commit/e431098c21afcc0ee791b9d7655ae0a1e… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M cmk/gui/wato/pages/services.py Log Message: ----------- service discovery: refactor Change-Id: I1cc025d3e9735b7a5b90c05c0c42433edf8feedf Commit: 7bc563ceb36599798f246447400e27675d13b9d6 https://github.com/tribe29/checkmk/commit/7bc563ceb36599798f246447400e27675… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M cmk/fetchers/_nofetcher.py Log Message: ----------- move error messages Listing messages in an enum makes (a bit) more sense than in a function called '_fetch_from_io'... Change-Id: If6bf91431fa51d227d4231bcf4198a7ddec4f878 Commit: d9f721c42bebebd30a766d3008b56ad620613ed7 https://github.com/tribe29/checkmk/commit/d9f721c42bebebd30a766d3008b56ad62… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A .werks/15525 M cmk/base/sources.py M cmk/fetchers/_nofetcher.py M cmk/gui/wato/pages/services.py Log Message: ----------- 15525 FIX Improve UI for edge cases in the service discovery page Change-Id: Ia20ac7b8380ba32a46007c941094b4c43c9bf18e Commit: 4ed5b25de68696e710cd18bedd1da5ec37511213 https://github.com/tribe29/checkmk/commit/4ed5b25de68696e710cd18bedd1da5ec3… Author: Teresa Siegmantel <teresa.siegmantel(a)tribe29.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M cmk/gui/fields/base.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py Log Message: ----------- rest-api: add stricter input validation to MultiNested I disabled pylint's too-many-branches check in _load_schemas as the branch I added is necessary to avoid crashes. CMK-12703 Change-Id: Ib96de2b90ce2c58cfb86d6408bae382e0c710d01 Compare: https://github.com/tribe29/checkmk/compare/f65eac0ca98b...4ed5b25de686