Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 892eeed1519f8d6cba230b473c91b44f9fe69cc3 https://github.com/Checkmk/checkmk/commit/892eeed1519f8d6cba230b473c91b44f9… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: A .werks/16788.md M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py M cmk/gui/openapi/endpoints/notification_rules/response_schemas.py Log Message: ----------- 16788 FIX notification_rules: encryption type now an enum When creating a notification rule via the REST-API with the plugin 'asciimail', and configuring the 'enable_sync_smtp field', you could previously set the subfield 'encryption' to any string. Any string is not a valid encryption type. This werk addresses this issue by having this field be an enum of two values which are * ssl_tls * starttls This aligns with the configuration options found in the UI for the same plugin. Change-Id: I6f283e6b55d3365acd6f8011df04dbc8d5fd474b Commit: ff8a206e33e2e7cc7cbc841e069430da99a58095 https://github.com/Checkmk/checkmk/commit/ff8a206e33e2e7cc7cbc841e069430da9… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py M cmk/gui/openapi/endpoints/notification_rules/response_schemas.py M cmk/utils/notify_types.py Log Message: ----------- notification rules: set defaults for the smtp auth fields When auth is enabled, in the UI the fields have defaults. This change aligns the REST-API with the UI in this behaviour. There is no visible change to the user, so I didn't include a werk. I also updated the descriptions in both the request & response schemas. Change-Id: I6da503b35f539e5e63a0cfd79c773c3b7e223e74 Commit: a43cf8b64207b1b866a1ab0457999e67809219c1 https://github.com/Checkmk/checkmk/commit/a43cf8b64207b1b866a1ab0457999e678… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: A .werks/17014.md M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py M cmk/gui/rest_api_types/notifications_rule_types.py Log Message: ----------- 17014 FIX notification_rules: auth value should be a required field when auth is enabled Previously, when you created a notification rule via the REST-API using the 'mail' plugin, the value of the 'auth' field within the "enable_sync_smtp" schema was not a required field. This is incorrect. If 'auth' is enabled, then the value of 'auth' should be a required field. This werk now addresses this issue. e.g ``` "enable_sync_smtp": { "state": "enabled", "value": { "auth": { "state": "enabled", "value": {"method": "plaintext", "password": "1234", "user": "user_a"}, }, "encryption": "ssl_tls", "port": 25, "smarthosts": ["abc", "def"], }, } ``` Change-Id: I018650850e6d4f1f26e76adb2669ce442e9cfb11 Compare: https://github.com/Checkmk/checkmk/compare/787c9ac4f25e...a43cf8b64207 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications