Branch: refs/heads/master
Home:
https://github.com/tribe29/checkmk
Commit: 2baff0aebdc280b79cb136761acd7686ca7354c9
https://github.com/tribe29/checkmk/commit/2baff0aebdc280b79cb136761acd7686c…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-11-19 (Thu, 19 Nov 2020)
Changed paths:
M cmk/base/checkers/_abstract.py
M cmk/base/checkers/agent.py
M cmk/base/checkers/snmp.py
M tests/unit/cmk/base/checkers/test_agent.py
M tests/unit/cmk/base/checkers/test_host_sections.py
Log Message:
-----------
Remove persisted sections from class
The persisted sections are only used in add_persisted_sections and
add_persisted_sections is only ever called *once* in the parsers.
We therefore make the data a parameter to add_persisted_sections instead
of an instance parameter.
This clarifies its usage while simplifying the HostSections class.
CMK-6362
Change-Id: I2a5c879a19014b7f6704b21a69b21fae771dcb85
Commit: 80905aff42c35e0c93d8eea073423eec5034e208
https://github.com/tribe29/checkmk/commit/80905aff42c35e0c93d8eea073423eec5…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-11-19 (Thu, 19 Nov 2020)
Changed paths:
M cmk/base/checkers/_abstract.py
M cmk/base/checkers/_cache.py
M cmk/base/checkers/agent.py
M cmk/base/checkers/snmp.py
Log Message:
-----------
Pass SectionStore instead of its particulars
We pass the SectionStore directly instead of the args required to
instantiate it.
See Also:
"Preserve Whole Object" (pp. 232-234) in "Refactoring" (1999) Fowler
CMK-6362
Change-Id: I727eb45ac3eb80fb1591a4983a48e16757b15573
Compare:
https://github.com/tribe29/checkmk/compare/cef03d10d6e0...80905aff42c3