[checkmk-commits] [tribe29/checkmk] 4ff3cd: Cleanup module

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4ff3cdb1a9dc2feacb11cb134adb47a802213cc0 https://github.com/tribe29/checkmk/commit/4ff3cdb1a9dc2feacb11cb134adb47a80… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-11 (Wed, 11 Nov 2020) Changed paths: M cmk/gui/wato/pages/audit_log.py M cmk/gui/wato/pages/sites.py M cmk/gui/watolib/changes.py M cmk/gui/watolib/groups.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/sites.py Log Message: ----------- Cleanup module * Move path computations to helper functions and use pathlib paths * Spread type hints in module * Remove six * Fix bugs uncovered by new type hints CMK-6187 Change-Id: I8ec2e8d5bd22e3e63bbfa14df57d0a1496a10fb1 Commit: 0eb609a426081532117da85c66cec62045720df3 https://github.com/tribe29/checkmk/commit/0eb609a426081532117da85c66cec6204… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-11 (Wed, 11 Nov 2020) Changed paths: M cmk/gui/watolib/__init__.py M cmk/gui/watolib/changes.py Log Message: ----------- Mark local helpers to be module internal Change-Id: I6347a45c32818ea30beecad72f310a59f59b7f67 Commit: 7859152b42c1b579b478b7ed4d64176c7c7a6368 https://github.com/tribe29/checkmk/commit/7859152b42c1b579b478b7ed4d64176c7… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-11 (Wed, 11 Nov 2020) Changed paths: M cmk/gui/wato/pages/audit_log.py M cmk/gui/watolib/changes.py Log Message: ----------- Move audit log reading to watolib First step to centralize audit log file IO in a dedicated class AuditLogStore. CMK-6187 Change-Id: I62d6f593a9cd08bf4ca9fa7ec8c9cfe57789cf74 Commit: 7953f1778878a2972283d0a6771b865c089b358a https://github.com/tribe29/checkmk/commit/7953f1778878a2972283d0a6771b865c0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-11 (Wed, 11 Nov 2020) Changed paths: M cmk/gui/watolib/changes.py Log Message: ----------- Move audit log writing to AuditLogStore CMK-6187 Change-Id: Ic98dab539ab5fe4e1ca4e9e0353dce359c561b7b Commit: 0031eb3063ff0f858ac0c0e37a835f30ce0d9784 https://github.com/tribe29/checkmk/commit/0031eb3063ff0f858ac0c0e37a835f30c… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-11 (Wed, 11 Nov 2020) Changed paths: A tests/unit/cmk/gui/watolib/test_changes.py Log Message: ----------- Add tests for audit log store CMK-6187 Change-Id: Iba776a5a812ed5c84a99c017212886d5e19f0ea5 Commit: ce83509a04ce2cbf33e7277731828f23268a564a https://github.com/tribe29/checkmk/commit/ce83509a04ce2cbf33e7277731828f232… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-11 (Wed, 11 Nov 2020) Changed paths: M cmk/gui/wato/pages/audit_log.py M cmk/gui/watolib/changes.py M tests/unit/cmk/gui/watolib/test_changes.py Log Message: ----------- Refactor audit log entry to namedtuple CMK-6187 Change-Id: I148b0ac0d9a231e11724bc2616c3a177a6f0d60b Commit: 3aedf466043ac27236ee91cc3bab354d7b6d4ca0 https://github.com/tribe29/checkmk/commit/3aedf466043ac27236ee91cc3bab354d7… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-11 (Wed, 11 Nov 2020) Changed paths: M cmk/gui/watolib/activate_changes.py M cmk/gui/watolib/changes.py Log Message: ----------- Align API of SiteChanges with AuditLogStore They will be consolidated in the next step. It is a good preparation to reduce the differences in advance to make the review of the merge easier. CMK-6187 Change-Id: I1fff532666847aae7635ec0e43d40da93595c61b Commit: e8ff174d488158aad4f156a91b3c7354adfe7924 https://github.com/tribe29/checkmk/commit/e8ff174d488158aad4f156a91b3c7354a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-11 (Wed, 11 Nov 2020) Changed paths: M tests/unit/cmk/gui/watolib/test_changes.py Log Message: ----------- Group audit log store tests Change-Id: I80073b7b6434122ea37de6915fa818dd8dace5d3 Commit: 236c52c17cce47899506536146b042fe6f3bba91 https://github.com/tribe29/checkmk/commit/236c52c17cce47899506536146b042fe6… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-11 (Wed, 11 Nov 2020) Changed paths: M cmk/gui/watolib/changes.py M tests/unit/cmk/gui/watolib/test_changes.py Log Message: ----------- Add tests for SiteChanges Change-Id: I4598f00b2b7f56a3af0b3b017fb19710d5ab8ca4 Commit: 34e292afe231a218c0dbcf14bdef9c1f479cfdda https://github.com/tribe29/checkmk/commit/34e292afe231a218c0dbcf14bdef9c1f4… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-11 (Wed, 11 Nov 2020) Changed paths: M cmk/gui/watolib/changes.py Log Message: ----------- Separate site changes file handling to abstract class The new audit log will use the same file format and will be able to share the IO logic easily. Change-Id: I2746d00a7dc0172e923fd85bce860add2a899829 Compare: https://github.com/tribe29/checkmk/compare/74dba4424e17...34e292afe231