16 Dec
2019
16 Dec
'19
5:41 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: ae79add54d889c45e1e426e1bdf675b1bc81eb4e
https://github.com/tribe29/checkmk/commit/ae79add54d889c45e1e426e1bdf675b1b…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2019-12-16 (Mon, 16 Dec 2019)
Changed paths:
A .werks/10123
Log Message:
-----------
10123 FIX Fixed race condition when changing host check command.
When the kind of a host check command was changed, e.g. from an active check
to smart ping, there was a small time window for scheduling to go wrong.
This resulted in endless log lines of the form "invalid command line '@foo'
for bar", and the only way to resume normal operation was to restart the
Checkmk Micro Core, reloading was not enough. This has been fixed.
Change-Id: I056880380bf61ff3e0ea0a1c5f84a8bca01843c4
Commit: 27e867c907eeadc83107e6fc47542845b62dc34c
https://github.com/tribe29/checkmk/commit/27e867c907eeadc83107e6fc47542845b…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2019-12-16 (Mon, 16 Dec 2019)
Changed paths:
R livestatus/src/AtomicInt32PointerColumn.h
R livestatus/src/FixedIntColumn.h
A livestatus/src/IntLambdaColumn.h
R livestatus/src/IntPointerColumn.h
M livestatus/src/TableServices.cc
M livestatus/src/TableStatus.cc
Log Message:
-----------
Get rid of pointer arithmetic (1)
This patch introduces a new Column type: `IntLambdaColumn` that takes a
functor taking no arguments and returning an int. The class does not
take Column::Offsets.
This new class could, in principle, replace the children of `IntColumn`
For now, it lets us remove the most trivial ones:
- FixedIntColumn
- IntPointerColumn
- AtomicInt32PointerColumn
This class does *not* access the values via pointer arithmetic
and is safer.
Note:
It cannot be used for columns that use pointer arithmetic as a
JOIN-ersatz. The JOIN-ersatz is an entirely different story and shall
be dealt with separately.
Change-Id: I49656213a3db45dab7e29e1c3b77504e56a23d22
Commit: be04e761bef3ed25a0bb5aa068d490d807d1c585
https://github.com/tribe29/checkmk/commit/be04e761bef3ed25a0bb5aa068d490d80…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2019-12-16 (Mon, 16 Dec 2019)
Changed paths:
M livestatus/src/IntLambdaColumn.h
M livestatus/src/TableServices.cc
M livestatus/src/TableStatus.cc
Log Message:
-----------
Get rid of pointer arithmetic (2)
Add two trivial wrappers for constant and ref columns
Change-Id: I49be1df759c42e262b64b13b0388c6919ede7f2f
Compare: https://github.com/tribe29/checkmk/compare/cc2be815423f...be04e761bef3