[checkmk-commits] 7071 FIX Fixed missing form error highlighting for cascaded dropdown fields

Module: check_mk Branch: master Commit: d6fd5f703e1cc81153483f58eac7ccfeb8cd2efb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d6fd5f703e1cc8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jan 15 17:28:59 2019 +0100 7071 FIX Fixed missing form error highlighting for cascaded dropdown fields Some dropdown fields were not highlighted in case there are input validation errors detected during form submit. This made it hard for the user to find the field that needs to be corrected. Change-Id: I6174434b506e6e3371410e5677ce25d741115b4c --- .werks/7071 | 13 +++++++++++++ cmk/gui/valuespec.py | 6 +++--- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/.werks/7071 b/.werks/7071 new file mode 100644 index 0000000..9183310 --- /dev/null +++ b/.werks/7071 @@ -0,0 +1,13 @@ +Title: Fixed missing form error highlighting for cascaded dropdown fields +Level: 1 +Component: multisite +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.6.0i1 +Date: 1547561948 + +Some dropdown fields were not highlighted in case there are input validation +errors detected during form submit. This made it hard for the user to find +the field that needs to be corrected. diff --git a/cmk/gui/valuespec.py b/cmk/gui/valuespec.py index d7f0f8a..c5b853d 100644 --- a/cmk/gui/valuespec.py +++ b/cmk/gui/valuespec.py @@ -2053,11 +2053,11 @@ class CascadingDropdown(ValueSpec): self._encoding_type.__name__) vs.validate_datatype(value[1], varprefix + "_%d" % nr) return - raise MKUserError(varprefix, _("Value %r is not allowed here.") % value) + raise MKUserError(varprefix + "_sel", _("Value %r is not allowed here.") % value) def validate_value(self, value, varprefix): if self._no_preselect and value == self._no_preselect_value: - raise MKUserError(varprefix, self._no_preselect_error) + raise MKUserError(varprefix + "_sel", self._no_preselect_error) choices = self.choices() for nr, (val, _title, vs) in enumerate(choices): @@ -2066,7 +2066,7 @@ class CascadingDropdown(ValueSpec): vs.validate_value(value[1], varprefix + "_%d" % nr) ValueSpec.custom_validate(self, value, varprefix) return - raise MKUserError(varprefix, _("Value %r is not allowed here.") % (value,)) + raise MKUserError(varprefix + "_sel", _("Value %r is not allowed here.") % (value,)) # The same logic as the dropdown choice, but rendered