[checkmk-commits] [tribe29/checkmk] 6197c4: modernize msi_engine #3

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6197c4fda07c0155062f167e9d37b67cbdc621f4 https://github.com/tribe29/checkmk/commit/6197c4fda07c0155062f167e9d37b67cb… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2022-08-11 (Thu, 11 Aug 2022) Changed paths: M cmk/utils/msi_engine.py Log Message: ----------- modernize msi_engine #3 Lesser refactoring CMK-4023 Change-Id: I3d286d91904b44eb8528c7e26e4684f563cc80b4 Commit: 281bb58aced7236f02ae485020d120855ab7974a https://github.com/tribe29/checkmk/commit/281bb58aced7236f02ae485020d120855… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2022-08-11 (Thu, 11 Aug 2022) Changed paths: A .werks/14361 M agents/wnx/src/engine/cma_core.cpp M agents/wnx/src/engine/cma_core.h M agents/wnx/watest/test-plugin.cpp Log Message: ----------- 14361 FIX Windows agent uses retry_count correctly Previously, Windows agent used retry_count as a maximal allowed count of plugin's failures. If the count of failures exceeded the limit set by retry_count, then the plugin had been excluded from execution. Such behavior may break monitoring or updating in some cases. Since this release, the retry_count is defined as a maximally allowed count of attempts to call a plugin before clearing the previously gathered data (also known as a cache). This approach is fully compliant with the documentation, the help and the functionality of the Linux agent. The incompatibility in this werk is limited by definition: the Windows agent will continue to call a plugin even if the number of errors exceeds retry_count. This is the same behavior as when retry_count is not set at all. IMPORTANT: Windows agent always ignores retry_count for synchronous plugins. Windows agent may decrease value of retry_count if the value is set too high. Change-Id: Ia1109fd10a5e4b90efd6a1fc894e3c99fb1fde46 Compare: https://github.com/tribe29/checkmk/compare/ea5bc8f7f4b5...281bb58aced7