[checkmk-commits] [tribe29/checkmk] 29dc6c: Make rules identifiable by unique IDs

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 29dc6cea437585a12d108f1c8caab03d8f3fba81 https://github.com/tribe29/checkmk/commit/29dc6cea437585a12d108f1c8caab03d8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-18 (Wed, 18 Nov 2020) Changed paths: M cmk/gui/wato/pages/rulesets.py M cmk/gui/watolib/rulesets.py M tests/unit/cmk/gui/watolib/test_gui_rulesets.py M tests/unit/cmk/test_update_config.py Log Message: ----------- Make rules identifiable by unique IDs Since the early days of Checkmk the rules were always referenced by their position in the rule set list plus the related folder. We have a problem with rules not being clearly identifiable: * Audit log only refers to *current* list position * Possible race conditions in "edit ruleset" actions * API calls can not be made directly on individual rules The new ID will be created once for all existing rules during update to Checkmk 2.0 and persisted for the whole lifetime of the rule. CMK-6369 Change-Id: I7188e8deaf5c2b86a85d0a64d6f88b202e57c1ac Commit: 550560484e2efaa95c7c2e3021ba06b83d0527c5 https://github.com/tribe29/checkmk/commit/550560484e2efaa95c7c2e3021ba06b83… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-18 (Wed, 18 Nov 2020) Changed paths: M cmk/gui/wato/pages/object_parameters.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/watolib/rulesets.py Log Message: ----------- Use rule IDs in GUI actions Use the new rule IDs for referencing rules during rule actions. CMK-6369 Change-Id: I30cf47eb61a6d7d92361ec71989a5db755c69383 Commit: 1777254c29efcf3844a2c0930bf77e53cebab78f https://github.com/tribe29/checkmk/commit/1777254c29efcf3844a2c0930bf77e53c… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-18 (Wed, 18 Nov 2020) Changed paths: M cmk/gui/wato/pages/rulesets.py M cmk/gui/watolib/rulesets.py Log Message: ----------- Cleanup dead code Change-Id: I852d7125a5c281d98410b553a1fa4e3cc64c3f57 Commit: 1b8e80f426ec3e8fe8ca7b73533e8a6a6c4e6809 https://github.com/tribe29/checkmk/commit/1b8e80f426ec3e8fe8ca7b73533e8a6a6… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-18 (Wed, 18 Nov 2020) Changed paths: M cmk/gui/wato/pages/rulesets.py Log Message: ----------- Make rule ID visible on rule edit page CMK-6369 Change-Id: I78f9f55dc468928c9ab752c6e05f534d8bce0ce5 Commit: 4edc9730a4d8c20d56a9e8056bda5f27834af7bc https://github.com/tribe29/checkmk/commit/4edc9730a4d8c20d56a9e8056bda5f278… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-18 (Wed, 18 Nov 2020) Changed paths: M cmk/gui/wato/pages/activate_changes.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/watolib/changes.py M cmk/gui/watolib/rulesets.py Log Message: ----------- Audit log: Add object reference for rule related changes CMK-6369 Change-Id: I1ce5e41079eac90efb32c8595e13e10e5ae6815d Commit: 45d5622b914c90aac9df8b441a7374c4da75fa71 https://github.com/tribe29/checkmk/commit/45d5622b914c90aac9df8b441a7374c4d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-18 (Wed, 18 Nov 2020) Changed paths: M cmk/gui/plugins/webapi/webapi.py M cmk/gui/wato/pages/activate_changes.py M cmk/gui/wato/pages/host_rename.py M cmk/gui/watolib/changes.py M cmk/gui/watolib/rulesets.py Log Message: ----------- Audit log: Add object reference for ruleset related changes Moving rules in rulesets is not a single rule related action. For this reason we add the whole ruleset as reference object to these entries. CMK-6369 Change-Id: Icf5d8ec5c87fe68695f95223ab6b8910fb0f56bd Commit: 803bc7f5fbf1f4971988a1a14a2abf38fede0ce2 https://github.com/tribe29/checkmk/commit/803bc7f5fbf1f4971988a1a14a2abf38f… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-18 (Wed, 18 Nov 2020) Changed paths: M cmk/gui/wato/pages/folders.py M cmk/gui/wato/pages/hosts.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/services.py M cmk/gui/wato/pages/users.py M cmk/gui/watolib/changes.py Log Message: ----------- Add filtered audit log links CMK-6370 Change-Id: Ibc51004b60e7219429eab7d66435df7b6188d9fa Commit: dafe410530356a8d03a1e86ff9989222abaaa12b https://github.com/tribe29/checkmk/commit/dafe410530356a8d03a1e86ff9989222a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-18 (Wed, 18 Nov 2020) Changed paths: M cmk/gui/wato/pages/audit_log.py M cmk/gui/watolib/changes.py Log Message: ----------- Make audit log filtering possible without transaction CMK-6370 Change-Id: I20825971e349d633aebeb5fc490865f3e6ebfde4 Commit: d477e06143b57ca96630d09f3a6e749dbacb23f5 https://github.com/tribe29/checkmk/commit/d477e06143b57ca96630d09f3a6e749db… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-18 (Wed, 18 Nov 2020) Changed paths: M cmk/gui/watolib/hosts_and_folders.py Log Message: ----------- Clarified "main directory" in host move audit log entries Change-Id: I9f8b9a09ad83e1d11ec1e2fb7b424c9f666617d6 Compare: https://github.com/tribe29/checkmk/compare/c86dba0d87a2...d477e06143b5