[checkmk-commits] [Checkmk/checkmk] 971e38: Graph rendering: Extract coordinate transformation...

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 971e38b5fcb54f0b2f0bc3dee68f6a21ca5aae35 https://github.com/Checkmk/checkmk/commit/971e38b5fcb54f0b2f0bc3dee68f6a21c… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M packages/cmk-frontend/src/js/modules/graphs.ts Log Message: ----------- Graph rendering: Extract coordinate transformation into separate type The goal is to extract the actual rendering code into separate functions. This facilitates the subsequent bug fixes. SUP-18828 Change-Id: I77c64f913d788057396694f6a64e453a70d370bb Commit: 0442eb188bfb9eab0ba4d4c62daa4b77868e7720 https://github.com/Checkmk/checkmk/commit/0442eb188bfb9eab0ba4d4c62daa4b778… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M packages/cmk-frontend/src/js/modules/graphs.ts Log Message: ----------- Graph rendering: Extract curve rendering into separate function The goal is to extract the actual rendering code into separate functions. This facilitates the subsequent bug fixes. SUP-18828 Change-Id: Ieae27c437a90f9ba4b68999249e8c7f5520b4309 Commit: 6648c326f99578b5989cefc5cf4d31d8be724340 https://github.com/Checkmk/checkmk/commit/6648c326f99578b5989cefc5cf4d31d8b… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M packages/cmk-frontend/src/js/modules/graphs.ts Log Message: ----------- Graph rendering: Use new curve rendering function also for area graphs We can divide the rendering of area graphs into two distinct steps: 1) Render the actual data curve. 2) Fill the area between the data and the time axis. SUP-18828 Change-Id: Id09ccf1a85953bdc907b97d1ad194a5e24b6b0b3 Commit: 4c9ba8cb7b62a10b1ce9c6cf14e2f0fd5bc380e9 https://github.com/Checkmk/checkmk/commit/4c9ba8cb7b62a10b1ce9c6cf14e2f0fd5… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M packages/cmk-frontend/src/js/modules/graphs.ts Log Message: ----------- Graph rendering: Extract area rendering into separate function The goal is to extract the actual rendering code into separate functions. This facilitates the subsequent bug fixes. SUP-18828 Change-Id: I98b0a40d6b85342677f144e68f5a718023faee29 Commit: 280da3add6b88f38768ea5884859c1435dab6013 https://github.com/Checkmk/checkmk/commit/280da3add6b88f38768ea5884859c1435… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M packages/cmk-frontend/src/js/modules/graphs.ts Log Message: ----------- Graph rendering: Respect lower vertical limit when rendering curves Before, curves were rendered below the limit into the area of the time axis labels. Now, we cut off at the limit by connecting the last point above the limit to a point directly on the limit. The time coordinate of this point is computed from the slope and intersect of the line that connects the last point above the limit with the first point below the limit. And similarly for the opposite case where we transition from below the limit to above the limit. Note that we don't have to worry about the upper vertical range limit, since the graph simply ends there. We can draw arbitrarily large vertical values. They simply won't be rendered if they are above the limit. We will describe this change in a joint werk after also fixing the area rendering, which suffers from the same bug. SUP-18828 Change-Id: Iae8bb7b98cbf03164269a136fb2a255f98f0aabe Commit: 91a7cc35b4541d5075e99ad9d7c29bb0e9225fcb https://github.com/Checkmk/checkmk/commit/91a7cc35b4541d5075e99ad9d7c29bb0e… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M packages/cmk-frontend/src/js/modules/graphs.ts Log Message: ----------- Graph rendering: Respect lower vertical limit when rendering areas Before, filled areas extended below the limit into the area of the time axis label. Now, we cut off at the limit, similarly to the curve rendering. When transitioning from above the limit to below or vice versa, we render a pentagon instead of a quadrilateral. The lower edge of the pentagon is exactly at the lower limit. Note that we don't have to worry about the upper vertical range limit, since the graph simply ends there. We can draw arbitrarily large vertical values. They simply won't be rendered if they are above the limit. We will describe this change in a joint werk in a follow-up commit. SUP-18828 Change-Id: Ib8007a413b6451b7e3b6e8c374b750437613edae Commit: ac5630d5c9ee95c40382b42f7429290a8345da12 https://github.com/Checkmk/checkmk/commit/ac5630d5c9ee95c40382b42f7429290a8… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: A .werks/16986.md Log Message: ----------- 16986 FIX Respect lower vertical range limit when rendering graphs SUP-18828 Change-Id: I9a902e492633d8ebe139daa5517c98e5516ab0d2 Compare: https://github.com/Checkmk/checkmk/compare/d931eb84b41b...ac5630d5c9ee To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications