[checkmk-commits] [tribe29/checkmk] 522dc8: discovery: Remove useless indirections

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 522dc8694416234ae81245d751291ec8e72cd7a1 https://github.com/tribe29/checkmk/commit/522dc8694416234ae81245d751291ec8e… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/base/agent_based/discovery/_discovered_services.py M cmk/base/agent_based/discovery/_host_labels.py R cmk/base/agent_based/discovery/_parameters.py M cmk/base/agent_based/discovery/utils.py Log Message: ----------- discovery: Remove useless indirections `get_discovery_parameters` and `get_host_label_parameters` only forwarded there arguments to `get_plugin_parameters`. Let's call this last function directly. CMK-12298 Change-Id: Ia0ef6c6afb4b5f2cdfb7ec52d5b7ebfbbea85fe8 Commit: 4de86e811db665d5fd9fb488516cecab932de468 https://github.com/tribe29/checkmk/commit/4de86e811db665d5fd9fb488516cecab9… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/base/agent_based/confcheckers.py M cmk/base/agent_based/discovery/_discovery.py M cmk/base/agent_based/discovery/_host_labels.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M cmk/base/agent_based/discovery/preview.py M cmk/checkers/__init__.py M cmk/checkers/_api.py Log Message: ----------- host label plugins: nominal typing - nominal typing: This let's us perform some impedance-mismatch the interface. It would also be nice if, at some point, we had a generic plugin interface that's common to discovery, checking, host labels, and inventory. But then, structural typing wouldn't work very well anymore. - get rid of pseudo-namespace: This isn't C. CMK-12298 Change-Id: I7484405daae231ff7ca9a9cd510345ac23f86396 Commit: 3a56a41f2a238c241215de3b961e3640f2c923e0 https://github.com/tribe29/checkmk/commit/3a56a41f2a238c241215de3b961e3640f… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/base/agent_based/confcheckers.py M cmk/base/agent_based/discovery/_discovered_services.py M cmk/base/agent_based/discovery/_discovery.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M cmk/base/agent_based/discovery/preview.py M cmk/base/config.py M cmk/checkers/__init__.py M cmk/checkers/_api.py M tests/unit/cmk/base/test_config.py Log Message: ----------- discovery plugins: nominal typing CMK-12298 Change-Id: I1f1575af814845c73897872eda6d28c7b8550967 Commit: 2a9a4da8162aaac74782736a42abc8409329faa3 https://github.com/tribe29/checkmk/commit/2a9a4da8162aaac74782736a42abc8409… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M tests/unit/cmk/base/plugins/agent_based/test_aws_status.py Log Message: ----------- Disabled broken test. Change-Id: I7182ade1225f70acbd7b9e06ab044e922e4e2c0d Commit: 16c7e5d4cf897ad54bac234ccee8408f0f0c8e1d https://github.com/tribe29/checkmk/commit/16c7e5d4cf897ad54bac234ccee8408f0… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M packages/cmk-agent-ctl/tests/test_pull.rs Log Message: ----------- add delay for windows to close socket before reconnect attempt - add custom message for flackiness diag Change-Id: I8da71a1057e43c466b511affe414fe42e0f9157d Commit: 865cf5d5e40f4ab3e16c62ac83b3ef1fbb34b571 https://github.com/tribe29/checkmk/commit/865cf5d5e40f4ab3e16c62ac83b3ef1fb… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M packages/cmk-agent-ctl/src/configuration/config.rs M packages/cmk-agent-ctl/src/modes/delete_connection.rs M packages/cmk-agent-ctl/src/modes/import_connection.rs M packages/cmk-agent-ctl/src/modes/registration.rs M packages/cmk-agent-ctl/src/modes/renew_certificate.rs M packages/cmk-agent-ctl/src/modes/status.rs Log Message: ----------- rework unit tests in controller #1 setup functionality moved to TestRegistry with a `build` pattern. Change-Id: Ib2c95ff18e9753ddc886ee94e9db0c75b193301d Commit: c5e2e2b7f2dce5483ec86aa33bffeee98dd33016 https://github.com/tribe29/checkmk/commit/c5e2e2b7f2dce5483ec86aa33bffeee98… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/13267 M cmk/utils/mailbox.py Log Message: ----------- 13267 FIX AttributeError: 'Namespace' object has no attribute 'fetch_client_id' in check_mail and check_mail_loop Trying to hide EWS related command line arguments from check_mail and check_mail_loop active checks (which don't support EWS yet) led to exceptions being raised due to invalid access to now non-existing arguments. This change makes those arguments visible again with a hint about EWS not being available. Change-Id: I51eb7c7c2294f882f076cfd670321ed59855b61a Commit: b0c832edc89d8074889537899a7edaa80eef7c10 https://github.com/tribe29/checkmk/commit/b0c832edc89d8074889537899a7edaa80… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M cmk/special_agents/agent_proxmox_ve.py Log Message: ----------- agent_proxmox_ve: improve error handling: handle ConnectionError which can occur even after successful connection Change-Id: I749857d2fbf1547528d1e288eb1dcbc9eb7dd458 Commit: 7db8eca7b038775b2b7379b4c75ce14ff216eb74 https://github.com/tribe29/checkmk/commit/7db8eca7b038775b2b7379b4c75ce14ff… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M scripts/run-bazel-build.sh Log Message: ----------- Print Bazel version before each build Change-Id: I477696c5439bf5cabce8bef1a21892c079fd7aea Commit: 4193522a2449704a27a246a4838598f3815b6212 https://github.com/tribe29/checkmk/commit/4193522a2449704a27a246a4838598f38… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/15450 M agents/mk-job M agents/mk-job.aix M agents/mk-job.solaris M cmk/base/plugins/agent_based/job.py M tests/unit/cmk/base/plugins/agent_based/test_job.py Log Message: ----------- 15450 FIX mk-job: improvements to state file persistence - address race conditions due to non-atomic file operations - start removing complexity due to trivial string manipulation Change-Id: I787cfefa8016799604a48d53dba942f2597f0cf5 Commit: 9c76bf4b396f235ff16939d3fc0b7a46bed623b5 https://github.com/tribe29/checkmk/commit/9c76bf4b396f235ff16939d3fc0b7a46b… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: A .werks/15666 M agents/mk-job.solaris Log Message: ----------- 15666 FIX mk-job.solaris: do not add artificial metrics Change-Id: I4213dd965c9ca48597d906c35be5c728ccd968dc Compare: https://github.com/tribe29/checkmk/compare/bc397ec05071...9c76bf4b396f