[checkmk-commits] 5203 FIX Removed sorting of perfometers

Module: check_mk Branch: master Commit: f93aab66082fdac2484fd95c5a4f7365e5ddd540 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f93aab66082fda… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 11 11:18:36 2017 +0200 5203 FIX Removed sorting of perfometers The user could interactively sort a view by the sorter by clicking on the column header. The sorter was not sorting by the shown value(s), but was simply using the first perfdata value of the service for sorting. This could be wrong since the base for the shown value is often not the first perfdata value. The broken sorting function has been removed now. Maybe we could add a more intelligent sorting in the future. For the moment you can create a custom view and add a sorter that sorts the view using a custom perfdata value. Change-Id: I855f873bcf597d6c97f62b7c1fbda248b57c5d6d --- .werks/5203 | 19 +++++++++++++++++++ web/plugins/views/perfometer.py | 1 - 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/.werks/5203 b/.werks/5203 new file mode 100644 index 0000000..8c3b0c2 --- /dev/null +++ b/.werks/5203 @@ -0,0 +1,19 @@ +Title: Removed sorting of perfometers +Level: 1 +Component: multisite +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1505121322 + +The user could interactively sort a view by the sorter by clicking on the column header. The +sorter was not sorting by the shown value(s), but was simply using the first perfdata value +of the service for sorting. This could be wrong since the base for the shown value is often +not the first perfdata value. + +The broken sorting function has been removed now. + +Maybe we could add a more intelligent sorting in the future. For the moment you can create +a custom view and add a sorter that sorts the view using a custom perfdata value. diff --git a/web/plugins/views/perfometer.py b/web/plugins/views/perfometer.py index 9e48662..f2077cc 100644 --- a/web/plugins/views/perfometer.py +++ b/web/plugins/views/perfometer.py @@ -207,7 +207,6 @@ multisite_painters["perfometer"] = { "columns" : [ "service_perf_data", "service_state", "service_check_command", "service_pnpgraph_present", "service_plugin_output" ], "paint" : paint_perfometer, - "sorter" : "svc_perf_val01", "printable" : "perfometer", # Special rendering in PDFs }