[checkmk-commits] [Checkmk/checkmk] 4cc55e: EC: implement dunder ne for StructuredDataName

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 4cc55e7e69aa5896ff98538a58b61f209b259218 https://github.com/Checkmk/checkmk/commit/4cc55e7e69aa5896ff98538a58b61f209… Author: Konstantin Baikov <konstantin.baikov(a)checkmk.com> Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M cmk/ec/syslog.py Log Message: ----------- EC: implement dunder ne for StructuredDataName If you implement __eq__ but not __ne__, then == and != will behave somewhat strangely, since the default implementation of __ne__ is based on identity, not the negation of equality. Quite often a class with only __eq__ will appear to work properly with !=, but it fails for various corner-cases (for example, an object which does not compare equal to itself, such as NaN). Change-Id: I1c2ef9f9d331430e46dc0357c7d6e96c110d1027 Commit: ac59ec668e500e0904b996a7456037cf6c8e724c https://github.com/Checkmk/checkmk/commit/ac59ec668e500e0904b996a7456037cf6… Author: Konstantin Baikov <konstantin.baikov(a)checkmk.com> Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M cmk/ec/syslog.py Log Message: ----------- EC: fix and aesthetic nitpick for dunder eq Avoids NOT and makes it even more obvious what the narrowed type for o.name is. And when one wants to make this eq more flexible by handling more types, one could add just another "if" of the same form. Change-Id: Ica10b852a245b29c898c61aa9df8bfd5049707b2 Compare: https://github.com/Checkmk/checkmk/compare/28f47f024c58...ac59ec668e50 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications