[checkmk-commits] [tribe29/checkmk] cf3be7: Refactor out query_data from cmk/gui/plugins/views...

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: cf3be7c15f94f47372d4fca80333147dee6a9478 https://github.com/tribe29/checkmk/commit/cf3be7c15f94f47372d4fca80333147de… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-06-18 (Tue, 18 Jun 2019) Changed paths: M cmk/gui/plugins/views/__init__.py M cmk/gui/plugins/views/bi.py M cmk/gui/plugins/views/datasources.py M cmk/gui/plugins/views/inventory.py M cmk/gui/plugins/views/mkeventd.py M cmk/gui/plugins/views/utils.py M cmk/gui/views.py Log Message: ----------- Refactor out query_data from cmk/gui/plugins/views/utils.py - Remove query_data & do_query_data. This functions where isolated from RowTable but make more sense as part of the RowTable query method. do_query_data is simplified to livestatusquery, and drops any formulation of the query language or data post-processing. - RowTable.query() method had parameter *query*, which is not the full query but mostly only some filters or extra instructions. It also gets always added to datasource.add_headers for the livestatus query. Thus rename to *headers* and update all inherited classes. - RowTableLivestatus refactored to use the new query method - ServiceDiscoveryRowTable refactored to follow new use of query - RowTableCustomers & DataSourceCustomer refactored to follow new use of query - _do_table_join directly uses RowTable.query instead of query_data - Graphs query data directly over helper function livestatusquery. CMK-2186 Change-Id: I3a3f884e8efcc16608285d733d1b474dd2daa13c Commit: ee186574513b8b07d331514adba9535dbf9ab62c https://github.com/tribe29/checkmk/commit/ee186574513b8b07d331514adba9535db… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-06-18 (Tue, 18 Jun 2019) Changed paths: M cmk/gui/plugins/metrics/utils.py M cmk/gui/plugins/views/utils.py M cmk/gui/valuespec.py M tests/unit/cmk/gui/plugins/test_metrics_utils.py Log Message: ----------- Painter for Processed Historic Metrics - Painter incorporates new concept of dynamic columns. Before livestatus query cell parameters can be recovered and RRDcolumns constructed. - Painter incorporates new concept of derive This function processes data immediately after Livestatus Datasource. It can work with all the rows at once, but only sequentially on the Cells. - Derive function hashes Cell parameters to identify processed columns at later stages - New ValueSpec MetricName. A DropdownChoice that gathers all known metrics in our system. For user then to pick one without having typos. Metrics not declared in our metric system can then unfortunately not be used at the moment. - Reverse metric_id translation. Go from canonical metric name to metric name used in the RRD archives. Works very well except for fs_used, which in the archives corresponds to mountpoints and the metric system translation use a regex in this case. CMK-2186 Change-Id: Ib4c44313fea2d4c332585d60418b08de5ca4181e Commit: f9fa69378d52e2d57cab43717755de8c385c4864 https://github.com/tribe29/checkmk/commit/f9fa69378d52e2d57cab43717755de8c3… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-06-18 (Tue, 18 Jun 2019) Changed paths: M cmk/gui/plugins/views/utils.py M cmk/gui/views.py Log Message: ----------- Sorter url parsing and encoding Change-Id: I4ea3cd450479ebe4e21517355d26155c9117c992 Commit: b47b1483dee88e22d8baeeea65a8a5c7260cba67 https://github.com/tribe29/checkmk/commit/b47b1483dee88e22d8baeeea65a8a5c72… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-06-18 (Tue, 18 Jun 2019) Changed paths: M cmk/gui/plugins/views/utils.py M web/htdocs/themes/classic/scss/_pages.scss Log Message: ----------- Remove unnecessary theme option since 2012 Change-Id: Idf6a8d7963234d9bf3723ea52274cb61414fd1a1 Commit: 345dfea73a8d6f46eab2c0137d960632bf86de95 https://github.com/tribe29/checkmk/commit/345dfea73a8d6f46eab2c0137d960632b… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-06-18 (Tue, 18 Jun 2019) Changed paths: M cmk/gui/plugins/views/utils.py M cmk/gui/views.py Log Message: ----------- Sorting on dynamic columns CMK-2181 Change-Id: I54f1e4e793ba302b2a53a5dbc694fb7f21a418b8 Commit: 35ae37f169f79bb077601a6433aaca1a41d524e3 https://github.com/tribe29/checkmk/commit/35ae37f169f79bb077601a6433aaca1a4… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-06-18 (Tue, 18 Jun 2019) Changed paths: M cmk/gui/views.py Log Message: ----------- Filter for Historic Metrics table Dynamically generated RRD columns are recognized by the filter system early in the process when they are collected for the view. This filter is not present in the service datasource despite the filter specification claiming that "host" enables it in the hosts and services views. Filters get always activated, instead of appearing when they are configured. This causes for example that the SW/HW query always happens, because that filter is active all the time. CMK-2182 Change-Id: I79d470334ddaadf16d8aceb10296b7f64a2e37c7 Commit: 6826ff21a6da8d2c415f7351ae37b966b8128abc https://github.com/tribe29/checkmk/commit/6826ff21a6da8d2c415f7351ae37b966b… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2019-06-18 (Tue, 18 Jun 2019) Changed paths: M cmk/gui/plugins/views/utils.py Log Message: ----------- Columns that deal with history data require a Title Since the content is dynamically generated based on RRD query and then statistical processing. It is mandatory to label this dynamically generated columns. A bit of a Hack is used as painter title should be static properties, nevertheless title functions are allowed for SLA and thus here we abuse the inheritance from painter and let title be a function with optional parameters. Works for GUI and PDF reports CMK-2185 Change-Id: Icc8579210345fcfd0c91cddb353beafd47dcde6f Compare: https://github.com/tribe29/checkmk/compare/0638f214401e...6826ff21a6da