[checkmk-commits] #2990 FIX netapp_api_vs_traffic: fixed incorrect CIFS latency

Module: check_mk Branch: master Commit: 9eaff0a7059d8507684f2aa866608dbb4f35b459 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9eaff0a7059d85… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Mon Feb 8 15:39:31 2016 +0100 #2990 FIX netapp_api_vs_traffic: fixed incorrect CIFS latency The CIFS latency was off by a factor of 1000. --- .werks/2990 | 9 +++++++++ ChangeLog | 1 + checks/netapp_api_vs_traffic | 12 ++++++------ 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/.werks/2990 b/.werks/2990 new file mode 100644 index 0000000..08e2d27 --- /dev/null +++ b/.werks/2990 @@ -0,0 +1,9 @@ +Title: netapp_api_vs_traffic: fixed incorrect CIFS latency +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1454942332 +Class: fix + +The CIFS latency was off by a factor of 1000. diff --git a/ChangeLog b/ChangeLog index 2226b9d..e853a3d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -259,6 +259,7 @@ * 3167 FIX: apc_inrow_airflow: fix exception in displaying parameters in WATO services list... * 3070 FIX: windows agent: replaced a very costy section regarding installed software... * 3071 FIX: cisco_mem, cisco_sys_mem, cisco_mem_asa: fixed incorrect unit being displayed... + * 2990 FIX: netapp_api_vs_traffic: fixed incorrect CIFS latency... Multisite: * 2684 Added icons for downloading agent data / walks of hosts... diff --git a/checks/netapp_api_vs_traffic b/checks/netapp_api_vs_traffic index 216fd29..0cccff6 100644 --- a/checks/netapp_api_vs_traffic +++ b/checks/netapp_api_vs_traffic @@ -48,20 +48,20 @@ def check_netapp_api_vs_traffic(item, _no_params, parsed): ("sent_packet", "if_out_pkts", "sent packets", 1, int)]), "fcp_lif:vserver": ("FCP", - [ ("avg_read_latency", "fcp_read_latency", "avg. Read latency", 0.001, lambda x: "%s ms" % (x * 1000)), - ("avg_write_latency", "fcp_write_latency", "avg. Write latency", 0.001, lambda x: "%s ms" % (x * 1000)), + [ ("avg_read_latency", "fcp_read_latency", "avg. Read latency", 0.001, lambda x: "%.2f ms" % (x * 1000)), + ("avg_write_latency", "fcp_write_latency", "avg. Write latency", 0.001, lambda x: "%.2f ms" % (x * 1000)), ("read_data", "fcp_read_data", "read data", 1, get_bytes_human_readable), ("write_data", "fcp_write_data", "write data", 1, get_bytes_human_readable)]), "cifs:vserver": ("CIFS", - [ ("cifs_read_latency", "cifs_read_latency", "read latency", 0.000001, lambda x: "%s ms" % (x * 1000)), - ("cifs_write_latency", "cifs_write_latency", "write latency", 0.000001, lambda x: "%s ms" % (x * 1000)), + [ ("cifs_read_latency", "cifs_read_latency", "read latency", 0.000001, lambda x: "%.2f ms" % x), + ("cifs_write_latency", "cifs_write_latency", "write latency", 0.000001, lambda x: "%.2f ms" % x), ("cifs_read_ops", "cifs_read_ios", "read OPs", 1, int), ("cifs_write_ops", "cifs_write_ios", "write OPs", 1, int)]), "iscsi_lif:vserver": ("iSCSI", - [ ("avg_read_latency", "iscsi_read_latency", "avg. Read latency", 0.001, lambda x: "%s ms" % (x * 1000)), - ("avg_write_latency", "iscsi_write_latency", "avg. Write latency", 0.001, lambda x: "%s ms" % (x * 1000)), + [ ("avg_read_latency", "iscsi_read_latency", "avg. Read latency", 0.001, lambda x: "%.2f ms" % (x * 1000)), + ("avg_write_latency", "iscsi_write_latency", "avg. Write latency", 0.001, lambda x: "%.2f ms" % (x * 1000)), ("read_data", "iscsi_read_data", "read data", 1, get_bytes_human_readable), ("write_data", "iscsi_write_data", "write data", 1, get_bytes_human_readable)]),