[checkmk-commits] [tribe29/checkmk] b1639a: Units: Introduce optional field for conversion

Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: b1639a98684aac3d3c529d259b66f70835264b3a https://github.com/tribe29/checkmk/commit/b1639a98684aac3d3c529d259b66f7083… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/unit.py M cmk/gui/type_defs.py Log Message: ----------- Units: Introduce optional field for conversion Since converting when doing the actual rendering is too late, we instead need a function to convert the actual data points. Also remove the current conversion mechanism for the temperature unit and add the new field instead. As of this commit, the conversion of the temperature unit is temporarily broken, until we apply the conversion to the various places where data is retrieved from livestatus. CMK-12958 Change-Id: Ie1c67d8c9064e47754ec739ba46ebd5c7aafb9f9 Commit: e3983816c2f80f3d86fcec3ad9bf1aa29a2da4e1 https://github.com/tribe29/checkmk/commit/e3983816c2f80f3d86fcec3ad9bf1aa29… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/utils/livestatus_helpers/testing.py Log Message: ----------- livestatus mocking: Add option to expect query for a single site This will be needed in the next commit for testing the conversion of queries RRD data according to the graph unit. CMK-12958 Change-Id: I657421bb6198fa45615fdccced4bfa135ae687eb Commit: 929b35f2f8b2f6707205e8400c75ff9f079fbc89 https://github.com/tribe29/checkmk/commit/929b35f2f8b2f6707205e8400c75ff9f0… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/utils/prediction.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py M tests/unit/cmk/utils/test_prediction_commons.py Log Message: ----------- Take unit conversions into account when fetching RRD data for graphs CMK-12958 Change-Id: Ie1003a7028cc90d6aef58cfa117f65986203eccf Commit: 7a23db16fd64a7ff596355d861a58f3942e38695 https://github.com/tribe29/checkmk/commit/7a23db16fd64a7ff596355d861a58f394… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py Log Message: ----------- Take unit conversions into account when merging multiple RRD columns This functionality is used in some dashlets and painters after fetching the data from livestatus. CMK-12958 Change-Id: If58351e2c2c69aa1b44b168708764023db2637c9 Commit: b22da1e7fe3bb7f8020d6e7dd9cc31b02a301b91 https://github.com/tribe29/checkmk/commit/b22da1e7fe3bb7f8020d6e7dd9cc31b02… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/type_defs.py Log Message: ----------- Historical & forecast metric painters: Simplify rendering The rendering was unnecessarily complicated: After computing the final value to be rendered, including metric translations and unit conversions, this value was transformed into a perfomance data string. This string was subsequently parsed to extract the numerical value. Not only is this unnecessary, it would also soon lead to applying unit conversions twice: Once after fetching the historical data and once after parsing the artificially created performance data string. CMK-12958 Change-Id: I578a5427924dc71228795c4410b007e3c6df5d51 Commit: b5e20fb99955ca189457232c0836b763baadd2fa https://github.com/tribe29/checkmk/commit/b5e20fb99955ca189457232c0836b763b… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py Log Message: ----------- Take unit conversions into account when translating parsed perf data This applies to perfometers, graph legends, some single-metric dashlets and some views. CMK-12958 Change-Id: Ic740407583a225230406fdabc3099cc81486e5f5 Commit: 8caca3d1f210babe5865b204372c02e3d8b75662 https://github.com/tribe29/checkmk/commit/8caca3d1f210babe5865b204372c02e3d… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/metrics.py Log Message: ----------- Take unit conversions into account when rendering perfometer labels We offer the option to put a constant number as a label. In this (probably never occuring) case, we should convert. CMK-12958 Change-Id: I5604dda4b976b2fcc45ddb66555682e05923712f Commit: 0df3a63600fbb03a3483502f92b6b17c12d7a6a7 https://github.com/tribe29/checkmk/commit/0df3a63600fbb03a3483502f92b6b17c1… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/metrics.py M tests/unit/cmk/gui/test_metrics.py Log Message: ----------- Take unit conversions into account when rendering linear perfometers CMK-12958 Change-Id: I174027bbdf611710d122ee3b8be6939f5a6f48a1 Commit: ef411d25a29107692b3abca9b76f752330524f3c https://github.com/tribe29/checkmk/commit/ef411d25a29107692b3abca9b76f75233… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M cmk/gui/metrics.py M tests/unit/cmk/gui/test_metrics.py Log Message: ----------- Take unit conversions into account when rendering logarithm. perfometers CMK-12958 Change-Id: I7c22ac544043895610c57119daafa7d1e84ab232 Compare: https://github.com/tribe29/checkmk/compare/f30b1a77e212...ef411d25a291