[checkmk-commits] [Checkmk/checkmk] c282a2: Refactoring: Simplify EOL handling in console.error

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: c282a214eb2414e9a871a5b33f1b8a743f7d2c44 https://github.com/Checkmk/checkmk/commit/c282a214eb2414e9a871a5b33f1b8a743… Author: Sven Panne <sven.panne(a)checkmk.com> Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: M bin/check_mk M cmk/base/api/agent_based/register/_discover.py M cmk/base/api/bakery/register.py M cmk/base/automations/__init__.py M cmk/base/config.py M cmk/base/core_nagios/_precompile_host_checks.py M cmk/base/modes/check_mk.py M cmk/base/notify.py M cmk/base/parent_scan.py M cmk/checkengine/discovery/_host_labels.py M cmk/checkengine/discovery/_services.py M cmk/utils/log/console.py M tests/unit/cmk/utils/test_log_console.py Log Message: ----------- Refactoring: Simplify EOL handling in console.error It doesn't make sense to go the extra mile to avoid emitting an EOL in print(), just to add that EOL at every call site. Note that one must be very careful when chaning such things in our code, because the console code is effectively used for three totally different purposes to emit: * fancy, perhaps colored output on the TTY * log lines in some log file * a fixed internal protocol Sometimes one doesn't even know actual the purpose, because the code in question is used in various scenarios. This is quite suboptimal and should really be disentangled, but this is something for future cleanups. Change-Id: I681ee1b567d2f04c33c055f63f97f38ebada5252 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications