17 Jun
2024
17 Jun
'24
3:44 a.m.
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: fcb5055b532279654c67ca6a4fa6599f729cdf45
https://github.com/Checkmk/checkmk/commit/fcb5055b532279654c67ca6a4fa6599f7…
Author: Maximilian Wirtz <maximilian.wirtz(a)checkmk.com>
Date: 2024-06-17 (Mon, 17 Jun 2024)
Changed paths:
M cmk/gui/painter/v0/painters.py
M cmk/gui/utils/html.py
M cmk/gui/view_utils.py
M cmk/gui/watolib/audit_log.py
M tests/unit/cmk/gui/utils/test_html.py
Log Message:
-----------
Make HTML().value private
Change-Id: I9ec8139f3b678ed057a2c98e635fba27826e6de5
Commit: efc19c1cdc834479fd92d417e6f1c2e386d45ef1
https://github.com/Checkmk/checkmk/commit/efc19c1cdc834479fd92d417e6f1c2e38…
Author: Maximilian Wirtz <maximilian.wirtz(a)checkmk.com>
Date: 2024-06-17 (Mon, 17 Jun 2024)
Changed paths:
M cmk/utils/escaping.py
Log Message:
-----------
Remove HTMLEscapedStr
Was not used.
Change-Id: I1ab23f943d2d550a9b43a6bf706395e16f560bdf
Commit: 675887ff001672503d64204debaddbcd75e85b3a
https://github.com/Checkmk/checkmk/commit/675887ff001672503d64204debaddbcd7…
Author: Maximilian Wirtz <maximilian.wirtz(a)checkmk.com>
Date: 2024-06-17 (Mon, 17 Jun 2024)
Changed paths:
M cmk/gui/utils/html.py
Log Message:
-----------
Be strict on input types and check on runtime
Better safe than sorry?
Change-Id: I9d84bfe9881e052ddf5078229f001cfbc42b6fe1
Commit: 62a211fb759b54e31edd7674c15c3ae032ab52a5
https://github.com/Checkmk/checkmk/commit/62a211fb759b54e31edd7674c15c3ae03…
Author: Maximilian Wirtz <maximilian.wirtz(a)checkmk.com>
Date: 2024-06-17 (Mon, 17 Jun 2024)
Changed paths:
M cmk/gui/utils/escaping.py
Log Message:
-----------
Add doctest
Change-Id: Ie9cb52aff7e9cdb0976efe5427933ed648e49a83
Commit: d9552aaaf20744d42a78b10633abc2886610cbfa
https://github.com/Checkmk/checkmk/commit/d9552aaaf20744d42a78b10633abc2886…
Author: Maximilian Wirtz <maximilian.wirtz(a)checkmk.com>
Date: 2024-06-17 (Mon, 17 Jun 2024)
Changed paths:
M cmk/gui/painter/v0/helpers.py
M cmk/gui/view_utils.py
Log Message:
-----------
Let `get_host_list_links` return HTML
Change-Id: Ia01c6628f8eb82a2471b2d3915356afa8428060b
Commit: cdefdad101c347b4003eadbdb2e913815dde142b
https://github.com/Checkmk/checkmk/commit/cdefdad101c347b4003eadbdb2e913815…
Author: Maximilian Wirtz <maximilian.wirtz(a)checkmk.com>
Date: 2024-06-17 (Mon, 17 Jun 2024)
Changed paths:
M cmk/cee/robotmk/pages/_suite_logs.py
M cmk/gui/bi/_config.py
M cmk/gui/bi/_snapins.py
M cmk/gui/bi/foldable_tree_renderer.py
M cmk/gui/bi/view.py
M cmk/gui/cce/agent_registration/_modes.py
M cmk/gui/cee/agent_bakery/_misc.py
M cmk/gui/cee/agent_bakery/_views.py
M cmk/gui/cee/alert_handling/_modes.py
M cmk/gui/cee/dashboard/_average_scatterplot_dashlet.py
M cmk/gui/cee/dashboard/_top_list.py
M cmk/gui/cee/ntop/_views.py
M cmk/gui/cee/ntop/pages.py
M cmk/gui/cee/sla/_painters.py
M cmk/gui/crash_reporting/pages.py
M cmk/gui/crash_reporting/views.py
M cmk/gui/dashboard/page_show_dashboard.py
M cmk/gui/graphing/_html_render.py
M cmk/gui/graphing/cee/_graphs.py
M cmk/gui/gui_background_job.py
M cmk/gui/htmllib/generator.py
M cmk/gui/htmllib/html.py
M cmk/gui/htmllib/tag_rendering.py
M cmk/gui/htmllib/top_heading.py
M cmk/gui/login.py
M cmk/gui/message.py
M cmk/gui/mkeventd/views.py
M cmk/gui/mkeventd/wato.py
M cmk/gui/mobile/pages.py
M cmk/gui/mobile/views.py
M cmk/gui/painter/v0/base.py
M cmk/gui/painter/v0/helpers.py
M cmk/gui/painter/v0/painters.py
M cmk/gui/sidebar/__init__.py
M cmk/gui/table.py
M cmk/gui/utils/escaping.py
M cmk/gui/utils/flashed_messages.py
M cmk/gui/utils/html.py
M cmk/gui/utils/rendering.py
M cmk/gui/valuespec/definitions.py
M cmk/gui/view_renderer.py
M cmk/gui/view_utils.py
M cmk/gui/views/availability.py
M cmk/gui/views/command/base.py
M cmk/gui/views/command/commands.py
M cmk/gui/views/icon/painter.py
M cmk/gui/views/inventory/_painters.py
M cmk/gui/views/inventory/_tree_renderer.py
M cmk/gui/views/perfometer/base.py
M cmk/gui/views/perfometer/painter.py
M cmk/gui/visuals/_add_to_visual.py
M cmk/gui/visuals/_filter_form.py
M cmk/gui/visuals/_filter_valuespecs.py
M cmk/gui/wato/_snapins.py
M cmk/gui/wato/pages/_host_attributes.py
M cmk/gui/wato/pages/activate_changes.py
M cmk/gui/wato/pages/audit_log.py
M cmk/gui/wato/pages/check_catalog.py
M cmk/gui/wato/pages/folders.py
M cmk/gui/wato/pages/global_settings.py
M cmk/gui/wato/pages/groups.py
M cmk/gui/wato/pages/host_rename.py
M cmk/gui/wato/pages/ldap.py
M cmk/gui/wato/pages/notifications.py
M cmk/gui/wato/pages/object_parameters.py
M cmk/gui/wato/pages/pattern_editor.py
M cmk/gui/wato/pages/roles.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/wato/pages/services.py
M cmk/gui/wato/pages/tags.py
M cmk/gui/wato/pages/user_profile/two_factor.py
M cmk/gui/wato/pages/users.py
M cmk/gui/wato/views.py
M cmk/gui/watolib/audit_log.py
M cmk/gui/watolib/builtin_attributes.py
M cmk/gui/watolib/config_domain_name.py
M cmk/gui/watolib/groups.py
M cmk/gui/werks.py
M tests/unit/cmk/gui/htmllib/test_html_cls.py
M tests/unit/cmk/gui/htmllib/test_tag_rendering.py
M tests/unit/cmk/gui/plugins/views/test_painters.py
M tests/unit/cmk/gui/test_escaping.py
M tests/unit/cmk/gui/test_table.py
M tests/unit/cmk/gui/test_view_utils.py
M tests/unit/cmk/gui/utils/test_flashed_messages.py
M tests/unit/cmk/gui/utils/test_html.py
M tests/unit/cmk/gui/utils/test_rendering.py
M tests/unit/cmk/gui/valuespecs/test_vs_alternative.py
M tests/unit/cmk/gui/valuespecs/test_vs_dictionary.py
M tests/unit/cmk/gui/valuespecs/test_vs_listofstrings.py
M tests/unit/cmk/gui/wato/pages/test_rulesets.py
M tests/unit/cmk/gui/watolib/test_changes.py
Log Message:
-----------
Rework HTML class
The previous API was sometimes misused and untrusted input was
converted into an HTML object. I guess one of the reasons is the tying
so if a function only accepts HTML and a dev needs to convert a str into
a HTML object that conversion was not obvious.
Since the HTML objects are nearly immutable we need to extend the
constructor. Making classmethods seems to be a good way to explicitly
state what should be done with the value.
CMK-17814
Change-Id: Iaa19365c4a6e760e73062cceed22bf17927ffb2c
Compare: https://github.com/Checkmk/checkmk/compare/c1ad66725480...cdefdad101c3
To unsubscribe from these emails, change your notification settings at
https://github.com/Checkmk/checkmk/settings/notifications