[checkmk-commits] [tribe29/checkmk] 179bff: Make context managers exception-safe.

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 179bff56b5f9781b62c3c1c2369819cddbd0ad72 https://github.com/tribe29/checkmk/commit/179bff56b5f9781b62c3c1c2369819cdd… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-04-14 (Fri, 14 Apr 2023) Changed paths: M agents/wnx/tests/integration/utils.py M cmk/base/plugins/agent_based/utils/ps.py M cmk/checkers/submitters.py M cmk/gui/backup.py M cmk/gui/bi/foldable_tree_renderer.py M cmk/gui/htmllib/foldable_container.py M cmk/gui/session.py M cmk/gui/sites.py M cmk/gui/views/page_show_view.py M cmk/gui/watolib/changes.py M cmk/gui/wsgi/applications/rest_api.py M cmk/update_config/plugins/actions/visuals_utils.py M cmk/utils/config_path.py M doc/helpers/import-memory M livestatus/api/python/livestatus.py M tests/testlib/users.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py Log Message: ----------- Make context managers exception-safe. Change-Id: Ic22c8b9aa0518ad317fd2f90d53c85976b6b3f67 Commit: 293c4ae83add3744528c0ff6640176a2c69bd592 https://github.com/tribe29/checkmk/commit/293c4ae83add3744528c0ff6640176a2c… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-14 (Fri, 14 Apr 2023) Changed paths: M tests/unit/cmk/utils/test_password_store.py Log Message: ----------- Do not monkeypatch by hand Change-Id: I44a63a92c24ac479729d16327dbd6630abbe13c9 Commit: 05defc5474bf8429b35fcee04a5eee477da1a573 https://github.com/tribe29/checkmk/commit/05defc5474bf8429b35fcee04a5eee477… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-14 (Fri, 14 Apr 2023) Changed paths: M cmk/utils/crypto/secrets.py Log Message: ----------- Avoid paths as default params Default arguments are bound on import and so are class variables. Local variables are bound on use. Now, our paths are patched in the tests and the tests do not control the imports. Thus, there is a non-zero chance that patching `omd_root`, `$OMD_ROOT`, and friends doesn't work as expected in the tests. This caused over 500 failing unit tests in an unrelated change. In short: if you mutate a constant (here, by changing the root of the paths) then it's not a constant. Having mutable default arguments in Python is asking for trouble. Change-Id: I6094eb08e1cb17cc24f28aa2f851d8384b4cd027 Commit: 1a71a91a395ae277caa8d4759ba4405e8700b36e https://github.com/tribe29/checkmk/commit/1a71a91a395ae277caa8d4759ba4405e8… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-04-14 (Fri, 14 Apr 2023) Changed paths: M cmk/base/_autochecks.py M cmk/base/agent_based/checking/_checking.py M cmk/base/agent_based/confcheckers.py M cmk/base/agent_based/discovery/_discovered_services.py M cmk/base/agent_based/discovery/_discovery.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M cmk/base/agent_based/discovery/preview.py M cmk/base/api/agent_based/checking_classes.py M cmk/base/api/agent_based/register/_config.py M cmk/base/api/agent_based/register/check_plugins.py M cmk/base/api/agent_based/register/utils.py M cmk/base/api/agent_based/value_store/_utils.py M cmk/base/automations/check_mk.py M cmk/base/config.py M cmk/base/core_config.py M cmk/base/core_nagios.py M cmk/base/export.py M cmk/base/modes/check_mk.py M cmk/base/plugins/agent_based/logwatch_ec.py M cmk/checkers/__init__.py M cmk/checkers/_api.py M cmk/checkers/check_table.py A cmk/checkers/checking.py M cmk/checkers/crash_reporting.py M cmk/checkers/discovery/_autochecks.py M cmk/checkers/plugin_contexts.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/update_config/plugins/actions/autochecks.py M cmk/update_config/plugins/actions/replaced_check_plugins.py M cmk/update_config/plugins/actions/rulesets.py M cmk/utils/type_defs/__init__.py M cmk/utils/type_defs/pluginname.py M tests/testlib/__init__.py M tests/unit/checks/generictests/run.py M tests/unit/checks/test_apc_mod_pdu_modules.py M tests/unit/checks/test_datapower_fan_legacy.py M tests/unit/checks/test_esx_vsphere_hostsystem_maintenance.py M tests/unit/checks/test_esx_vsphere_hostsystem_multipath.py M tests/unit/checks/test_esx_vsphere_hostsystem_state.py M tests/unit/checks/test_filestats.py M tests/unit/checks/test_graylog_sources.py M tests/unit/checks/test_hp_proliant_raid.py M tests/unit/checks/test_mem_win.py M tests/unit/checks/test_mongodb_collections.py M tests/unit/checks/test_mongodb_replica_set.py M tests/unit/checks/test_mssql_instance.py M tests/unit/checks/test_oracle_instance_uptime.py M tests/unit/checks/test_oracle_recovery_status.py M tests/unit/checks/test_scaleio_devices.py M tests/unit/cmk/base/agent_based/checking/test_cluster_modes.py M tests/unit/cmk/base/agent_based/discovery/test_discovered_services.py M tests/unit/cmk/base/agent_based/discovery/test_discovery.py M tests/unit/cmk/base/api/agent_based/register/test__config.py M tests/unit/cmk/base/api/agent_based/register/test_check_plugins.py M tests/unit/cmk/base/api/agent_based/register/test_check_plugins_legacy.py M tests/unit/cmk/base/api/agent_based/register/test_export.py M tests/unit/cmk/base/api/agent_based/test_utils_check_levels_predictive.py M tests/unit/cmk/base/api/agent_based/value_store/test_vs_global_state.py M tests/unit/cmk/base/api/agent_based/value_store/test_vs_utils.py M tests/unit/cmk/base/autochecks/test_autochecks.py M tests/unit/cmk/base/autochecks/test_autochecks_utils.py M tests/unit/cmk/base/plugins/agent_based/test_bluecat_threads.py M tests/unit/cmk/base/plugins/agent_based/test_brocade_fcport.py M tests/unit/cmk/base/plugins/agent_based/test_cisco_fru_module_status.py M tests/unit/cmk/base/plugins/agent_based/test_cisco_wlc_clients.py M tests/unit/cmk/base/plugins/agent_based/test_cmciii.py M tests/unit/cmk/base/plugins/agent_based/test_container_cpu.py M tests/unit/cmk/base/plugins/agent_based/test_diskstat.py M tests/unit/cmk/base/plugins/agent_based/test_docker_container_diskstat.py M tests/unit/cmk/base/plugins/agent_based/test_docker_container_mem.py M tests/unit/cmk/base/plugins/agent_based/test_fast_lta_headunit_replication.py M tests/unit/cmk/base/plugins/agent_based/test_fast_lta_headunit_status.py M tests/unit/cmk/base/plugins/agent_based/test_fast_lta_silent_cubes_capacity.py M tests/unit/cmk/base/plugins/agent_based/test_fast_lta_volumes.py M tests/unit/cmk/base/plugins/agent_based/test_fireeye_active_vms.py M tests/unit/cmk/base/plugins/agent_based/test_fireeye_mailq.py M tests/unit/cmk/base/plugins/agent_based/test_fireeye_quarantine.py M tests/unit/cmk/base/plugins/agent_based/test_juniper_fru.py M tests/unit/cmk/base/plugins/agent_based/test_k8s_pod_container.py M tests/unit/cmk/base/plugins/agent_based/test_lsi.py M tests/unit/cmk/base/plugins/agent_based/test_megaraid_bbu.py M tests/unit/cmk/base/plugins/agent_based/test_mssql_blocked_sessions.py M tests/unit/cmk/base/plugins/agent_based/test_mssql_instance.py M tests/unit/cmk/base/plugins/agent_based/test_netapp_api_disk.py M tests/unit/cmk/base/plugins/agent_based/test_netapp_api_qtree_quota.py M tests/unit/cmk/base/plugins/agent_based/test_netapp_api_temp.py M tests/unit/cmk/base/plugins/agent_based/test_oracle_dataguard_stats.py M tests/unit/cmk/base/plugins/agent_based/test_oracle_instance.py M tests/unit/cmk/base/plugins/agent_based/test_oracle_processes.py M tests/unit/cmk/base/plugins/agent_based/test_oracle_recovery_area.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_db_status.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_diskusage.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_ess.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_events.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_fileinfo.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_instance_status.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_memrate.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_proc.py M tests/unit/cmk/base/plugins/agent_based/test_sap_hana_replication_status.py M tests/unit/cmk/base/plugins/agent_based/test_suseconnect.py M tests/unit/cmk/base/plugins/agent_based/test_timemachine.py M tests/unit/cmk/base/plugins/agent_based/test_ucs_c_rack_server_psu_voltage.py M tests/unit/cmk/base/plugins/agent_based/test_ups_test.py M tests/unit/cmk/base/plugins/agent_based/test_vutlan_ems_smoke.py M tests/unit/cmk/base/plugins/agent_based/test_windows_update.py M tests/unit/cmk/base/sources/test_snmp_data_source.py M tests/unit/cmk/base/test_check_table.py M tests/unit/cmk/base/test_check_utils.py M tests/unit/cmk/base/test_config.py M tests/unit/cmk/base/test_core_config.py M tests/unit/cmk/base/test_core_nagios.py M tests/unit/cmk/update_config/plugins/actions/test_rulesets.py M tests/unit/cmk/utils/rulesets/test_ruleset_matcher.py M tests/unit/cmk/utils/test_man_pages.py M tests/unit/cmk/utils/type_defs/test_type_defs_plugin_name.py Log Message: ----------- Move plugin names to check engine #2 Change-Id: Iff72cbce4b210d405b1328ce4055b4a349b3c993 Commit: c0eb382f2c0ec274438fac49aad60362b243cd4f https://github.com/tribe29/checkmk/commit/c0eb382f2c0ec274438fac49aad60362b… Author: Mazen Alkatlabee <mazen.alkatlabee(a)tribe29.com> Date: 2023-04-14 (Fri, 14 Apr 2023) Changed paths: M web/htdocs/js/modules/bi.ts Log Message: ----------- fix a bug related to adding a new input field after introducing a new variable instead of using the old one to refer to two different things, I used the old value by mistake instead of the new one in some functions which changed the behavior and led to an error. Change-Id: Ica0ee71177014ba92c8decd9fb43aa950dd93ab9 Commit: 5a71b7ac84589f0e84b773c35703ccc40e57193f https://github.com/tribe29/checkmk/commit/5a71b7ac84589f0e84b773c35703ccc40… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2023-04-14 (Fri, 14 Apr 2023) Changed paths: M cmk/gui/watolib/agent_registration.py Log Message: ----------- avoid logging of warning if host list is full ok Change-Id: I2c7dea04c981da49d3b1453c5e7f711f78f7d770 Compare: https://github.com/tribe29/checkmk/compare/53a75552c335...5a71b7ac8458