16 Aug
2023
16 Aug
'23
9:44 a.m.
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 9230320166fc1aa3702d48cff41d9510e91be6aa
https://github.com/Checkmk/checkmk/commit/9230320166fc1aa3702d48cff41d9510e…
Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com>
Date: 2023-08-16 (Wed, 16 Aug 2023)
Changed paths:
M agents/wnx/install/resources/check_mk.user.yml
M agents/wnx/install/resources/check_mk.yml
M agents/wnx/src/common/cfg_yaml.h
M agents/wnx/src/engine/cfg.cpp
M agents/wnx/src/engine/engine.vcxproj
M agents/wnx/src/engine/engine.vcxproj.filters
A agents/wnx/src/engine/extensions.cpp
A agents/wnx/src/engine/extensions.h
A agents/wnx/watest/test-extensions.cpp
M agents/wnx/watest/test-yaml.cpp
M agents/wnx/watest/watest.vcxproj
M agents/wnx/watest/watest.vcxproj.filters
Log Message:
-----------
add config support fro robot_mk
Change-Id: Ib1a0d31125420d266bd2e042a555f63a1c730012
Commit: 26cfe6d8b38bdc2fbd5a870dafe4d686a2236699
https://github.com/Checkmk/checkmk/commit/26cfe6d8b38bdc2fbd5a870dafe4d686a…
Author: Leonardo Petrora <leonardo.petrora(a)checkmk.com>
Date: 2023-08-16 (Wed, 16 Aug 2023)
Changed paths:
A .werks/16051
M cmk/gui/livestatus_utils/commands/comment.py
M cmk/gui/plugins/openapi/endpoints/comment/__init__.py
M cmk/gui/plugins/openapi/endpoints/comment/request_schemas.py
M cmk/gui/plugins/openapi/endpoints/comment/response_schemas.py
M tests/testlib/rest_api_client.py
M tests/unit/cmk/gui/plugins/openapi/test_service_and_host_comments.py
Log Message:
-----------
16051 FIX comments: add site property to the comments endpoints
This werk introduces several changes to the comments endpoints.
1. Comment IDs are integers beginning from 1, both for the main site & for
remote sites. This means that the same comment ID can exist on more than
one site at the same time. This caused problems when calling the DELETE
endpoint as we weren't sure which ID the client wanted to delete.
To get around this problem, we have introduced a mandatory "site_id" field
which the client has to specify when they want to delete a comment.
2. Like point 1, calling GET comment with only a comment ID could also cause
the same problem. Therefore we have also introduced the mandatory "site_id"
query parameter field here too.
3. Now that the site_id field is mandatory in both the DELETE and GET comment
endpoints, we now return the site_id field as a comment attribute in both the
show comment and show comments endpoints.
4. This last change introduces a new optional query parameter on the show
all comments endpoint. The client can now specify the site_id as a filter,
so that they can list all comments for a specific site.
Change-Id: I8900beb49e7b3b057082aa4eb366f0daf5af4374
Compare: https://github.com/Checkmk/checkmk/compare/12f91635a9eb...26cfe6d8b38b