[checkmk-commits] [tribe29/checkmk] ff3297: Add attribute change tracking

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ff3297ef90b67e9529c8f414d91a029264bb6b03 https://github.com/tribe29/checkmk/commit/ff3297ef90b67e9529c8f414d91a02926… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-16 (Mon, 16 Nov 2020) Changed paths: M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/users.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/rulesets.py M cmk/gui/watolib/users.py Log Message: ----------- Add attribute change tracking Now comes the hard work: Spread the attribute tracking for audit log to all individual places that make changes to objects. This change adds it to the first important places: * Adding hosts * Editing hosts * Bulk edit / cleanup of hosts * Adding folders * Editing folders * Adding users * Editing users * Adding rules * Editing rules * Moving rules Change-Id: I0ee545c48a92d13ad103b41c4ab9821174c7cdd5 Commit: 9b509f2ab77cf5017e25e200bfb6a6208eb37ff0 https://github.com/tribe29/checkmk/commit/9b509f2ab77cf5017e25e200bfb6a6208… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-16 (Mon, 16 Nov 2020) Changed paths: M cmk/gui/wato/pages/audit_log.py Log Message: ----------- Fix double escaping of audit log messages Change-Id: I0b2523dd2c3cec2e368f0da788d35a465d02a4b0 Commit: 1bcaacb61a20ac36b9427b9280ff390979a6f50d https://github.com/tribe29/checkmk/commit/1bcaacb61a20ac36b9427b9280ff39097… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-16 (Mon, 16 Nov 2020) Changed paths: M cmk/gui/wato/pages/audit_log.py M cmk/gui/watolib/changes.py M cmk/gui/watolib/services.py M cmk/utils/object_diff.py Log Message: ----------- Add detailed logging of servces changed with single host discovery CMK-6332 Change-Id: I217c2fa02774c44bbf9664c41d1cc81fe9ced3a4 Commit: b0a501caa011e9f41f6be9217f758a6dcb529799 https://github.com/tribe29/checkmk/commit/b0a501caa011e9f41f6be9217f758a6dc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-16 (Mon, 16 Nov 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/discovery.py M cmk/gui/plugins/webapi/webapi.py M cmk/gui/watolib/automations.py M cmk/gui/watolib/bulk_discovery.py M cmk/gui/watolib/services.py M cmk/utils/type_defs/_misc.py M tests/unit/cmk/base/test_discovery.py Log Message: ----------- Cleanup typing of automation discovery (aka inventory) call We now have the type AutomationDiscoveryResult and helper types that clarify the typing of the involved data structures in the Base and GUI code base. This is a preparation for extending the exchanged data with a text that describes the changes to the services, which will then be written to the WATO audit log. CMK-6332 Change-Id: I604d93eaf173f3e17b3a656e9a40dc6ec5a739de Commit: 97805cbf15be4a9c1514aafa45bacf4e49373b8a https://github.com/tribe29/checkmk/commit/97805cbf15be4a9c1514aafa45bacf4e4… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-16 (Mon, 16 Nov 2020) Changed paths: M cmk/gui/plugins/wato/__init__.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/watolib/__init__.py M cmk/gui/watolib/changes.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/rulesets.py M cmk/gui/watolib/services.py M cmk/gui/watolib/users.py M tests/unit/cmk/gui/watolib/test_changes.py Log Message: ----------- Extract object diff calculation from log functions Turns out it is better to keep the diff text calculation separate from the change log entry logging. The separation allows us to get the diff text from another process without the need to transport the whole old and new data structures. This is useful when automations, which have the modified data structure, are executed on remote sites and have to respond with the diff. This is the case with the "inventory" automation. CMK-6332 Change-Id: I9d2dd4ed32b7572bb1b5609863c68b822a714602 Commit: 7b76dcec377adb544795f21d9cd16a19b5bff536 https://github.com/tribe29/checkmk/commit/7b76dcec377adb544795f21d9cd16a19b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-16 (Mon, 16 Nov 2020) Changed paths: M cmk/gui/watolib/services.py Log Message: ----------- Fix bulk disabling services on service discovery page Change-Id: I4f3e4497bffea5aff2cc734ab62a3a80a5730e9d Commit: 89250b1d80e85577e098f94d3b38c222e3dd378d https://github.com/tribe29/checkmk/commit/89250b1d80e85577e098f94d3b38c222e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-16 (Mon, 16 Nov 2020) Changed paths: M cmk/base/discovery.py M cmk/gui/watolib/bulk_discovery.py M cmk/gui/watolib/services.py M cmk/utils/type_defs/_misc.py Log Message: ----------- Add detailed logging of services changed with bulk host discovery Since the actual list of services is never transported to the GUI, the differences need to be calculated in Checkmk base (on the remote site). CMK-6332 Change-Id: Id994331839dbb226e2ff572aa99a8ce7edbdf919 Commit: 4bad917772dc9b94104069832c4940cfc3a3f527 https://github.com/tribe29/checkmk/commit/4bad917772dc9b94104069832c4940cfc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-11-16 (Mon, 16 Nov 2020) Changed paths: M cmk/gui/wato/pages/audit_log.py Log Message: ----------- Audit log: Improve rendering * Displaying details can be enabled and disabled * Fix details column width CMK-6332 Change-Id: Ifd7edfd67e3fdfb16f470807afe727c82bde6393 Compare: https://github.com/tribe29/checkmk/compare/fd797e96e567...4bad917772dc