[checkmk-commits] [tribe29/checkmk] 45b9cc: mcafee_av_client: minor refactoring

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 45b9ccf8edd3185ac2a0e20f92a10233c8cb2569 https://github.com/tribe29/checkmk/commit/45b9ccf8edd3185ac2a0e20f92a10233c… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-01-18 (Mon, 18 Jan 2021) Changed paths: M checks/mcafee_av_client Log Message: ----------- mcafee_av_client: minor refactoring Change-Id: I338ba22184a3b1c100310b0ac14d38ad82c555df Commit: 88352580e71abd5a5a193970cf089db4bf27ca89 https://github.com/tribe29/checkmk/commit/88352580e71abd5a5a193970cf089db4b… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-01-18 (Mon, 18 Jan 2021) Changed paths: M checks/mcafee_av_client Log Message: ----------- PRO TIP: use check_levels Many check plugins compare a value against a pair of thresholds to determine a state. If you do something like that, you should always use the provided function `check_levels`. It is available in the old API (in this example) and in the new check API. Change-Id: I7a06abc75ce953a0c74f81670b78cc9dd1b7f8d4 Commit: 65807eb561f049604c94c89b8f6bc92da20055fc https://github.com/tribe29/checkmk/commit/65807eb561f049604c94c89b8f6bc92da… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-01-18 (Mon, 18 Jan 2021) Changed paths: M cmk/gui/plugins/wato/check_parameters/mcafee_av_client.py Log Message: ----------- PRO TIP: make check parameters a dictionary In the new check API the parameters of the check funtion must be a dictionary. If you are migrating a plugin that uses (old-style) tuple or list parameters, you must implement a transformation function. It must be able to read old parameters that may already be configured, and convert them to the new dictionary format. Change-Id: I764159bbc140e495a904ce844311f736115af4b0 Commit: c3e897728e3ab26ba536a633f9694404f665d976 https://github.com/tribe29/checkmk/commit/c3e897728e3ab26ba536a633f9694404f… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-01-18 (Mon, 18 Jan 2021) Changed paths: M checks/mcafee_av_client Log Message: ----------- PRO TIP: Transforms are applied during `cmk-update-config` Since Checkmk 2.0 the transformation of check parameters defined in WATO rules is now applied during `cmk-update-config`. As long as a transformation is present in the corresponding WATO rule the check plugin no longer needs to handle the previous format. In this case, the transformation can be found in `cmk/gui/plugins/wato/check_parameters/mcafee_av_client.py`. Change-Id: I55cdcf9d32252f8335adc2d7eb5f0efd328d3837 Compare: https://github.com/tribe29/checkmk/compare/dd70a71a4326...c3e897728e3a