Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: c49bae4494013f2d7700d0394bb43f611e445c30
https://github.com/Checkmk/checkmk/commit/c49bae4494013f2d7700d0394bb43f611…
Author: Zoey Hilton <zoey.hilton(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
A .werks/16830.md
M cmk/gui/userdb/session.py
M cmk/gui/wato/_check_mk_configuration.py
M cmk/gui/wato/pages/user_profile/two_factor.py
M tests/gui_e2e/test_totp.py
M tests/testlib/playwright/pom/login.py
Log Message:
-----------
16830 SEC Bruteforce protection for two factor authentication
Prior to this werk, Two Factor Authentication failures could not trigger account lockout. All methods' failures will now count towards failed login attempts against a user's account.
As a result, an attacker could try to brute-force and therefore bypass user's two factor protections without triggering the lockout mechanism.
Change-Id: Ibe893e4885a72a6a1760ee51351a7aa0f427994c
To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 04fc9a0992aae08a7daa1d2a85596563d1c4a3ed
https://github.com/Checkmk/checkmk/commit/04fc9a0992aae08a7daa1d2a85596563d…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/gui/plugins/wato/check_parameters/raid.py
M cmk/plugins/collection/agent_based/lsi.py
Log Message:
-----------
lsi_array: fix rendering of default parameters
Change-Id: I5fe78d0b1c559924f2588b10103b96f22a105fe1
Commit: 9f1af7bd6eaed30e6c88a33e94aa1777e48e092f
https://github.com/Checkmk/checkmk/commit/9f1af7bd6eaed30e6c88a33e94aa1777e…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/validate_plugins.py
Log Message:
-----------
validation: presence of ruleset implies params
Change-Id: I4e6fd284f912896e4cb423ff80231566922264a6
Commit: d50e7dd88af083995de237bd62bf071abf367f2d
https://github.com/Checkmk/checkmk/commit/d50e7dd88af083995de237bd62bf071ab…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/validate_plugins.py
Log Message:
-----------
plugin validation: also consider enforced service rules
Change-Id: Ief2617580797302b7dc2f89c89680ed9d79ce1b3
Commit: b1f4f3f15cfc4ea6dd4ebdb61c37d5767cec6460
https://github.com/Checkmk/checkmk/commit/b1f4f3f15cfc4ea6dd4ebdb61c37d5767…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/base/automations/check_mk.py
M cmk/base/config.py
M cmk/base/core.py
M cmk/base/core_config.py
M cmk/base/ip_lookup.py
M cmk/base/modes/check_mk.py
M cmk/utils/config_warnings.py
M tests/unit/cmk/base/test_core_config.py
Log Message:
-----------
Untangle ip lookup error handler
We no longer add the failed lookups to the global variable,
but rather just collect them.
In the cases where we actually look at the global variable,
we now add the the warnings separately.
The logging that was previously a side effect of the collecting
is now done explicitly -- I am unsure as to when it is actually
desired, though.
Change-Id: Ibb9929ec75451641c4f02ae781f6c6b05e2e1f13
Commit: dbc3c58aa9caaae7b51195ebe3cf44f8b8496ea1
https://github.com/Checkmk/checkmk/commit/dbc3c58aa9caaae7b51195ebe3cf44f8b…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/base/automations/check_mk.py
M cmk/base/ip_lookup.py
M tests/unit/cmk/base/test_ip_lookup.py
Log Message:
-----------
Reland "make IP lookup mandatory"
This reverts commit 796611eaba059b3c59859c704739b3c53408f052.
Change-Id: I8d35b8e04c44b94b3453684eba10aeaebe95ba8c
Compare: https://github.com/Checkmk/checkmk/compare/ad9ee4e7e949...dbc3c58aa9ca
To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications
Branch: refs/heads/2.3.0
Home: https://github.com/Checkmk/checkmk
Commit: c90d542c02ca54c5ba6acaa100ca1c8c171e0cab
https://github.com/Checkmk/checkmk/commit/c90d542c02ca54c5ba6acaa100ca1c8c1…
Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
R tests/unit/checks/generictests/datasets/testfile_veeam_jobs_5c458152d3827_regression.py
A tests/unit/cmk/base/plugins/agent_based/test_veeam_jobs.py
Log Message:
-----------
veeam_jobs: migrate test
SUP-18723
Change-Id: Ibe6e7b7d4282d5e716d68fa32c9e2a821ee1f650
Commit: 3a0ae6ac3c836a4bd0fd4b8a011acd7174056e97
https://github.com/Checkmk/checkmk/commit/3a0ae6ac3c836a4bd0fd4b8a011acd717…
Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M tests/unit/cmk/base/plugins/agent_based/test_veeam_jobs.py
Log Message:
-----------
cover all cases in agent outputs
SUP-18723
Change-Id: Ib8aaa223d88a60642434eed9d503294479102b98
Commit: 3fe07b76bfc55244b6ad62aee1b3c24da730e809
https://github.com/Checkmk/checkmk/commit/3fe07b76bfc55244b6ad62aee1b3c24da…
Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
R cmk/base/legacy_checks/veeam_jobs.py
A cmk/base/plugins/agent_based/veeam_jobs.py
M tests/unit/checks/test_generic_legacy_conversion.py
M tests/unit/cmk/base/plugins/agent_based/test_veeam_jobs.py
Log Message:
-----------
veeam_jobs: migrate check
SUP-18723
Change-Id: I003f4c7f2d6cb8f63a27c45fba4d8e6a38fcdd75
Commit: e8194da78b93f9505b2a041badccc39cca95efed
https://github.com/Checkmk/checkmk/commit/e8194da78b93f9505b2a041badccc39cc…
Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/base/plugins/agent_based/veeam_jobs.py
Log Message:
-----------
veeam_jobs: factor parse function out
SUP-18723
Change-Id: Ia13a96e7ad0a9726120807e71a1f054c2b134c20
Commit: 0fd1050c59732462c4e70762f5521bf5a6801535
https://github.com/Checkmk/checkmk/commit/0fd1050c59732462c4e70762f5521bf5a…
Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/base/plugins/agent_based/veeam_jobs.py
Log Message:
-----------
veeam_jobs: delete comment
This agent ouput is not valid, since it does not have tab seperators. It
also does not cover any cases relevant to monitoring.
SUP-18723
Change-Id: I14ef26714326622d24f70f99c9db7cf1785619c3
Commit: 21b101caecbb83ae3e9320e72a1c46625a53e97d
https://github.com/Checkmk/checkmk/commit/21b101caecbb83ae3e9320e72a1c46625…
Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/base/plugins/agent_based/veeam_jobs.py
M tests/unit/cmk/base/plugins/agent_based/test_veeam_jobs.py
Log Message:
-----------
veeam_jobs: make overall look consistent
Omitting the information does little for our customers.
SUP-18723
Change-Id: I4c2fa72ea316361597202d694ffad16cb4bea350
Commit: 6c35b627bc149a457cc57a35878bf7fcc82129ce
https://github.com/Checkmk/checkmk/commit/6c35b627bc149a457cc57a35878bf7fcc…
Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/base/plugins/agent_based/veeam_jobs.py
M tests/unit/cmk/base/plugins/agent_based/test_veeam_jobs.py
Log Message:
-----------
veeam_jobs: move state functionality out
SUP-18723
Change-Id: I0ad5aaf8172e5c3a02b69840f9298a37d1c196f7
Commit: d34916012bcdef659b0d6709fc8765b092f6b8e2
https://github.com/Checkmk/checkmk/commit/d34916012bcdef659b0d6709fc8765b09…
Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
A .werks/16430.md
M cmk/base/plugins/agent_based/veeam_jobs.py
M tests/unit/cmk/base/plugins/agent_based/test_veeam_jobs.py
Log Message:
-----------
16430 FIX veeam_jobs: Always Monitor Result of Last Backup
SUP-18979
Change-Id: Ibd752d677b885350db2d0e828e10371daf1bceb3
Commit: c6d78ef279478fbc525df34a7e7249ad74b935f3
https://github.com/Checkmk/checkmk/commit/c6d78ef279478fbc525df34a7e7249ad7…
Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M .werks/16430.md
M cmk/base/plugins/agent_based/veeam_jobs.py
M cmk/plugins/collection/checkman/veeam_jobs
M tests/unit/cmk/base/plugins/agent_based/test_veeam_jobs.py
Log Message:
-----------
veeam_jobs: fix monitoring states
SUP-18723
Change-Id: I035c8e1698a3e13eb75a967c96513f9da2948d5e
Commit: 51dd12570d309e4e6415bf58452dd3040de3a476
https://github.com/Checkmk/checkmk/commit/51dd12570d309e4e6415bf58452dd3040…
Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/base/plugins/agent_based/veeam_jobs.py
Log Message:
-----------
veeam_jobs: delete lying comment
Comment can't be true based on our Agent Ouput, see unit test.
SUP-18723
Change-Id: Ia98b8135d16576ffc8dca77f232b4375ddf68f17
Compare: https://github.com/Checkmk/checkmk/compare/f1e056d7af95...51dd12570d30
To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: 95e18452a0d303a3ab6682d09d609266e074b98c
https://github.com/Checkmk/checkmk/commit/95e18452a0d303a3ab6682d09d609266e…
Author: Ronny Bruska <ronny.bruska(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/base/core_config.py
M cmk/base/core_nagios/_create_config.py
M cmk/utils/labels.py
M cmk/utils/notify.py
M tests/unit/cmk/base/test_core_config.py
M tests/unit/cmk/base/test_events.py
M tests/unit/cmk/utils/test_notify.py
Log Message:
-----------
Add tags with groups to core config file
* first preperation to match against group and id
* already in place for host and service labels
* path in latest config changed to notify/host_config/HOSTNAME
SUP-17094
Change-Id: I43d12aff5852e40d4efa4f18f6dd5541515ee92c
Commit: 8c5ac8bca2f03023a5e037f434602999e61e67b7
https://github.com/Checkmk/checkmk/commit/8c5ac8bca2f03023a5e037f434602999e…
Author: Ronny Bruska <ronny.bruska(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/base/events.py
Log Message:
-----------
Use tags from notify config file
SUP-17094
Change-Id: I9b9cdd81370b9a35bb6c196ab6139385ede19359
Commit: cac264af30ae7f5c96375771f1f5df252c980422
https://github.com/Checkmk/checkmk/commit/cac264af30ae7f5c96375771f1f5df252…
Author: Ronny Bruska <ronny.bruska(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/gui/openapi/marshmallow_converter/valuespec_to_marshmallow.py
M cmk/gui/wato/pages/_match_conditions.py
M cmk/gui/watolib/notifications.py
A cmk/update_config/plugins/actions/tag_conditions.py
M cmk/utils/notify_types.py
A tests/unit/cmk/update_config/plugins/actions/test_tag_conditions.py
Log Message:
-----------
Convert notification tag conditions to dict on update
* use DictHostTagCondition from now on
* other configuration of call sites (e.g. Event console) follows
* disabled REST-API tests, see CMK-17644
SUP-17094
Change-Id: I05369ee18a10ff366ea23218180a06e5a05b007b
Commit: 96745198c72e13b01a9b13f9ac2f4d335de12981
https://github.com/Checkmk/checkmk/commit/96745198c72e13b01a9b13f9ac2f4d335…
Author: Ronny Bruska <ronny.bruska(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/update_config/plugins/actions/global_settings.py
M cmk/update_config/plugins/actions/tag_conditions.py
M tests/unit/cmk/update_config/plugins/actions/test_global_settings.py
M tests/unit/cmk/update_config/plugins/actions/test_tag_conditions.py
Log Message:
-----------
Convert agent deployment tag condition to new format
SUP-17094
Change-Id: I9bf9a54e6f9eec5ed774788c1efdff32421651ae
Commit: 825120d08cad44c3173d76cc6e0dd9f0f820e354
https://github.com/Checkmk/checkmk/commit/825120d08cad44c3173d76cc6e0dd9f0f…
Author: Ronny Bruska <ronny.bruska(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/update_config/plugins/actions/tag_conditions.py
M tests/unit/cmk/update_config/plugins/actions/test_tag_conditions.py
Log Message:
-----------
Adjust naming of notification tag condition update step
SUP-17094
Change-Id: I817afc12ee246df91f7bbe0089a3aeadb42cfa6c
Commit: 2a7b00bc29129aa78de4350425afd2f654e3c1fe
https://github.com/Checkmk/checkmk/commit/2a7b00bc29129aa78de4350425afd2f65…
Author: Ronny Bruska <ronny.bruska(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
M cmk/base/events.py
M tests/unit/cmk/base/test_events.py
Log Message:
-----------
Switch to new tag matching
SUP-17094
Change-Id: I232354591af84005fe746e7ab0fac11dd54875cd
Commit: 72f235f2bef7df15eaef48ef36f06ac567837264
https://github.com/Checkmk/checkmk/commit/72f235f2bef7df15eaef48ef36f06ac56…
Author: Gav <gavin.mcguigan(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
A .werks/17015.md
M cmk/gui/fields/custom_fields.py
M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py
M cmk/gui/openapi/endpoints/notification_rules/response_schemas.py
M cmk/gui/rest_api_types/notifications_rule_types.py
M cmk/gui/watolib/notifications.py
M cmk/utils/rulesets/ruleset_matcher.py
M tests/unit/cmk/gui/openapi/test_notification_rules.py
Log Message:
-----------
17015 FIX notification rules: match_host_tag field update
Due to some format changes on the host tags, the rule notification
REST-API endpoints have also been affected. This werk takes these changes
into account. To do this, the possible enum values for a tag group has
been modified.
The match_host_tags field takes accepts a list of aux_tags or tag_groups.
For tag groups, we now accept two new operators.
Previously, the enum looked like
enum=["is", "is_not"]
and now it looks like
enum=["is", "is_not", "one_of", "none_of"]
In addition, when the operator field is one of the new values, we expect
a list of tag_ids and not a single tag_id.
Tag group using one of the previous enum values (no change here)
'''
{
"operator": "is"
"tag_id": "tagid"
}
'''
Tag group using one of the new new enum values
'''
{
"operator": "one_of",
"tag_ids": ["tagid_1", "tagid2", "tagid3"],
}
'''
CMK-17644
Change-Id: I7d3d0f33d4edc15a4a80dbb3c5d5b89d0341cadd
Compare: https://github.com/Checkmk/checkmk/compare/a41a789fd35a...72f235f2bef7
To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: a41a789fd35a59772a1098b77fdb9f0a8bcea3f1
https://github.com/Checkmk/checkmk/commit/a41a789fd35a59772a1098b77fdb9f0a8…
Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
Date: 2024-06-07 (Fri, 07 Jun 2024)
Changed paths:
R cmk/base/plugins/agent_based/win_computersystem.py
R cmk/base/plugins/agent_based/win_computersystemproduct.py
R cmk/base/plugins/agent_based/win_cpuinfo.py
R cmk/base/plugins/agent_based/win_dhcp_pools.py
R cmk/base/plugins/agent_based/win_os.py
R cmk/base/plugins/agent_based/win_system.py
R cmk/base/plugins/agent_based/windows_intel_bonding.py
R cmk/base/plugins/agent_based/windows_os_bonding.py
R cmk/base/plugins/agent_based/windows_tasks.py
R cmk/base/plugins/agent_based/windows_updates.py
R cmk/base/plugins/agent_based/winperf_if.py
R cmk/base/plugins/agent_based/winperf_msx_queues.py
R cmk/base/plugins/agent_based/winperf_phydisk.py
R cmk/base/plugins/agent_based/winperf_processor.py
R cmk/base/plugins/agent_based/winperf_tcp_conn.py
R cmk/base/plugins/agent_based/wlc_clients.py
R cmk/base/plugins/agent_based/wmi_cpuload.py
R cmk/base/plugins/agent_based/wut_webio.py
A cmk/plugins/collection/agent_based/win_computersystem.py
A cmk/plugins/collection/agent_based/win_computersystemproduct.py
A cmk/plugins/collection/agent_based/win_cpuinfo.py
A cmk/plugins/collection/agent_based/win_dhcp_pools.py
A cmk/plugins/collection/agent_based/win_os.py
A cmk/plugins/collection/agent_based/win_system.py
A cmk/plugins/collection/agent_based/windows_intel_bonding.py
A cmk/plugins/collection/agent_based/windows_os_bonding.py
A cmk/plugins/collection/agent_based/windows_tasks.py
A cmk/plugins/collection/agent_based/windows_updates.py
A cmk/plugins/collection/agent_based/winperf_if.py
A cmk/plugins/collection/agent_based/winperf_msx_queues.py
A cmk/plugins/collection/agent_based/winperf_phydisk.py
A cmk/plugins/collection/agent_based/winperf_processor.py
A cmk/plugins/collection/agent_based/winperf_tcp_conn.py
A cmk/plugins/collection/agent_based/wlc_clients.py
A cmk/plugins/collection/agent_based/wmi_cpuload.py
A cmk/plugins/collection/agent_based/wut_webio.py
R tests/unit/cmk/base/plugins/agent_based/test_win_computersystem.py
R tests/unit/cmk/base/plugins/agent_based/test_win_computersystemproduct.py
R tests/unit/cmk/base/plugins/agent_based/test_win_cpuinfo.py
R tests/unit/cmk/base/plugins/agent_based/test_win_dhcp_pools.py
R tests/unit/cmk/base/plugins/agent_based/test_win_os.py
R tests/unit/cmk/base/plugins/agent_based/test_win_system.py
R tests/unit/cmk/base/plugins/agent_based/test_windows_intel_bonding.py
R tests/unit/cmk/base/plugins/agent_based/test_windows_tasks.py
R tests/unit/cmk/base/plugins/agent_based/test_windows_update.py
R tests/unit/cmk/base/plugins/agent_based/test_winperf_if.py
R tests/unit/cmk/base/plugins/agent_based/test_winperf_msx_queues.py
R tests/unit/cmk/base/plugins/agent_based/test_winperf_phydisk.py
R tests/unit/cmk/base/plugins/agent_based/test_winperf_processor.py
R tests/unit/cmk/base/plugins/agent_based/test_wmi_cpuload.py
R tests/unit/cmk/base/plugins/agent_based/test_wut_webio.py
M tests/unit/cmk/plugins/collection/agent_based/test_aruba_wlc_clients.py
M tests/unit/cmk/plugins/collection/agent_based/test_cisco_wlc_clients.py
A tests/unit/cmk/plugins/collection/agent_based/test_win_computersystem.py
A tests/unit/cmk/plugins/collection/agent_based/test_win_computersystemproduct.py
A tests/unit/cmk/plugins/collection/agent_based/test_win_cpuinfo.py
A tests/unit/cmk/plugins/collection/agent_based/test_win_dhcp_pools.py
A tests/unit/cmk/plugins/collection/agent_based/test_win_os.py
A tests/unit/cmk/plugins/collection/agent_based/test_win_system.py
A tests/unit/cmk/plugins/collection/agent_based/test_windows_intel_bonding.py
A tests/unit/cmk/plugins/collection/agent_based/test_windows_tasks.py
A tests/unit/cmk/plugins/collection/agent_based/test_windows_update.py
A tests/unit/cmk/plugins/collection/agent_based/test_winperf_if.py
A tests/unit/cmk/plugins/collection/agent_based/test_winperf_msx_queues.py
A tests/unit/cmk/plugins/collection/agent_based/test_winperf_phydisk.py
A tests/unit/cmk/plugins/collection/agent_based/test_winperf_processor.py
A tests/unit/cmk/plugins/collection/agent_based/test_wmi_cpuload.py
A tests/unit/cmk/plugins/collection/agent_based/test_wut_webio.py
Log Message:
-----------
agent_based migration: w*
Change-Id: I9b9b930483325b611ab705b6bef46d6c255611fb
To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications