Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64357 discussions

[Checkmk/checkmk] 4f1318: test_update: Fix base-version used for SaaS

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 4f1318b6017b5640bef9f50f18e68dca4450d0b5 https://github.com/Checkmk/checkmk/commit/4f1318b6017b5640bef9f50f18e68dca4… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M tests/update/conftest.py Log Message: ----------- test_update: Fix base-version used for SaaS Branch details were accidentally removed. Change-Id: I0b4e9eef7e2483a45be1111913829f471463ff33 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months, 3 weeks

[Checkmk/checkmk] edfe1d: 16830 SEC Bruteforce protection for two factor aut...

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: edfe1d4c852a893334a80fad3618f646fbcf78a0 https://github.com/Checkmk/checkmk/commit/edfe1d4c852a893334a80fad3618f646f… Author: Zoey Hilton <zoey.hilton(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: A .werks/16830.md M cmk/gui/userdb/session.py M cmk/gui/wato/_check_mk_configuration.py M cmk/gui/wato/pages/user_profile/two_factor.py M tests/gui_e2e/test_totp.py M tests/testlib/playwright/pom/login.py Log Message: ----------- 16830 SEC Bruteforce protection for two factor authentication Prior to this werk, Two Factor Authentication failures could not trigger account lockout. All methods' failures will now count towards failed login attempts against a user's account. As a result, an attacker could try to brute-force and therefore bypass user's two factor protections without triggering the lockout mechanism. Change-Id: Ibe893e4885a72a6a1760ee51351a7aa0f427994c To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months, 3 weeks

[Checkmk/checkmk] 7b20fd: test_checks_sanity: add new parametrization for ac...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 7b20fd577eafcae120796f7f956454611bdd53ef https://github.com/Checkmk/checkmk/commit/7b20fd577eafcae120796f7f956454611… Author: Anastasiia Shevchuk <anastasiia.shevchuk(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M tests/integration/checks/test_checks_sanity.py M tests/testlib/site.py Log Message: ----------- test_checks_sanity: add new parametrization for active/passive mode As a part of CMK-15435 a new parameter was introduced to run the test in 'passive' (without triggering the checks) or 'active' (reschedule the Check_MK service) mode Change-Id: I1d81baf23d57efb9d9c13f39769c14aed1b90189 Commit: a8963bf654b2ab97ddc8fe5e818898f2a110286d https://github.com/Checkmk/checkmk/commit/a8963bf654b2ab97ddc8fe5e818898f2a… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/instance.rs M packages/mk-sql/src/utils.rs Log Message: ----------- mk-sql: remove carriage return from error message Change-Id: Ifaff6fcde2c9e9fa1539d07fa00604ea4037cc23 Commit: c677a4372215625caa1f6e3d05938b50314b2020 https://github.com/Checkmk/checkmk/commit/c677a4372215625caa1f6e3d05938b503… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/instance.rs M packages/mk-sql/src/ms_sql/sqls.rs Log Message: ----------- mk-sql: add SPACE_USED fallback for old SQL servers 2008 doesnt support RESULt we must use exec sp_spaceused Change-Id: I98c24ac87701c620e819c1911393844afb4e69f0 Commit: f680e11ecc3f2dd8ca273bc45e8808303b55165a https://github.com/Checkmk/checkmk/commit/f680e11ecc3f2dd8ca273bc45e8808303… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/instance.rs Log Message: ----------- mk-sql: calc unused value in sp_spaceused Change-Id: I7aedeeb68de15ee29684037fde986687f268a155 Commit: c4ec28a3a5c01018b180a1bfed1b7e48054e7d06 https://github.com/Checkmk/checkmk/commit/c4ec28a3a5c01018b180a1bfed1b7e480… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/instance.rs M packages/mk-sql/src/utils.rs M packages/mk-sql/tests/test_ms_sql.rs Log Message: ----------- mk-sql: fix error message Prepend with 'ERROR:' Change-Id: I8b2683b69492fef8d92767e3dbf81f48816d9c87 Commit: 21755cf110292dab66f294913ccf824ff95e4063 https://github.com/Checkmk/checkmk/commit/21755cf110292dab66f294913ccf824ff… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/client.rs M packages/mk-sql/src/ms_sql/instance.rs Log Message: ----------- mk-sql: set local timeout connection to 1 second It is difficult to imagine if timeout is higher. Need to improve performance when port is not available. Change-Id: I65fa4b2c0aaa998eccb147fbb0482f51eea3e381 Commit: 0ef58ca2561d1b9c376a29445dac06386f69af19 https://github.com/Checkmk/checkmk/commit/0ef58ca2561d1b9c376a29445dac06386… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: A .werks/16839.md Log Message: ----------- 16839 mk-sql ensures instance name is correct The plugin verifies whether the name of the instance at the specified address matches the name indicated in the config. If the name specified in the config does not match the instance name that responds, the monitoring of this instance will return an error. Example: The config mistakenly indicates that the `SQLEXPRESS` instance is located at `localhost:1433`, whereas the `MSSQLSERVER` instance is actually located at this address. Previously, the instance `MSSQLSERVER` were mistakenly monitored as `SQLEXPRESS`. Starting from this release, this error has been corrected. You need to correct the config if your config contained bad data. Change-Id: I687f018ff753c259b624f966e8d3a7b6d97b44f5 Commit: 7b34670c4fa8c7ef97e5f440376171e9ef59fc08 https://github.com/Checkmk/checkmk/commit/7b34670c4fa8c7ef97e5f440376171e9e… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: R .werks/16839.md Log Message: ----------- Revert "16839 mk-sql ensures instance name is correct" This reverts commit 0ef58ca2561d1b9c376a29445dac06386f69af19. Compare: https://github.com/Checkmk/checkmk/compare/f1531e44402a...7b34670c4fa8 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months, 3 weeks

[Checkmk/checkmk] 87956a: Reserved 20 Werk IDS

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 87956a5df7a0e935702fe649048b8e11dc73f674 https://github.com/Checkmk/checkmk/commit/87956a5df7a0e935702fe649048b8e11d… Author: Luka Racic <luka.racic(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M .werks/first_free Log Message: ----------- Reserved 20 Werk IDS Change-Id: I73d6f3116804be66626bb28b1fed035f4d6470c2 Commit: d2f423adc098237e43c662d4796e441430c700c1 https://github.com/Checkmk/checkmk/commit/d2f423adc098237e43c662d4796e44143… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/client.rs M packages/mk-sql/src/ms_sql/instance.rs M packages/mk-sql/src/ms_sql/query.rs M packages/mk-sql/src/platform.rs M packages/mk-sql/tests/common/tools.rs Log Message: ----------- mk-sql: add odbc support to UniAnswer Change-Id: I1e5ce3ce40a05817a80668a8639d37945a545bda Commit: f1531e44402a4f626c6b9f4272cc0a57345c1b79 https://github.com/Checkmk/checkmk/commit/f1531e44402a4f626c6b9f4272cc0a573… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/client.rs M packages/mk-sql/src/ms_sql/instance.rs M packages/mk-sql/src/ms_sql/query.rs M packages/mk-sql/src/platform.rs M packages/mk-sql/src/setup.rs M packages/mk-sql/tests/test_ms_sql.rs Log Message: ----------- mk-sql: full odbc support for local instances do not supporting tcp Some points: - more intelligent disabling of logs to prevent spam from odbc - no compound statement for the ODBC(it doesnt work well) - we have to use "Database=" instead of "Initial Catalog=" Tests. Local, manual with disabling TCP Change-Id: I84777b7d4d6d460edeaad6c6da57fed70c876441 Compare: https://github.com/Checkmk/checkmk/compare/9253450de78b...f1531e44402a To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months, 3 weeks

[Checkmk/checkmk] b5feed: mk-sql: make UniClient

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: b5feedb3070b943d03e28bd33d7245e3e5868e9b https://github.com/Checkmk/checkmk/commit/b5feedb3070b943d03e28bd33d7245e3e… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/client.rs M packages/mk-sql/src/ms_sql/instance.rs M packages/mk-sql/src/ms_sql/query.rs M packages/mk-sql/tests/common/tools.rs M packages/mk-sql/tests/test_ms_sql.rs Log Message: ----------- mk-sql: make UniClient represents at the moment only StdClient, i.e. tiberius Change-Id: I87e309dd2c16d6216d61384042afb294e909fc14 Commit: 9253450de78b04bc2c52fad82b10201ae0785824 https://github.com/Checkmk/checkmk/commit/9253450de78b04bc2c52fad82b10201ae… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/instance.rs M packages/mk-sql/src/ms_sql/query.rs M packages/mk-sql/src/ms_sql/section.rs M packages/mk-sql/tests/common/tools.rs Log Message: ----------- mk-sql: add UniAnswer as an "abstraction" layer - keeps answers from the client, at the moment works only with tiberius::Row in next commit will support also String Change-Id: I4506e99587c70e70d5dcf3624e62cff6dbd71e7c Compare: https://github.com/Checkmk/checkmk/compare/0ba4253039c9...9253450de78b To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months, 3 weeks

[Checkmk/checkmk] 879f6e: mk-sql: discover ODBC driver names automatically

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 879f6e144a990617df904b26e33913bc62947c55 https://github.com/Checkmk/checkmk/commit/879f6e144a990617df904b26e33913bc6… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/platform.rs Log Message: ----------- mk-sql: discover ODBC driver names automatically Change-Id: Ie4c320c0be98d32265a7857678cd21012637574d Commit: e20d5580b796ea41d84d57c3a2043514504970cf https://github.com/Checkmk/checkmk/commit/e20d5580b796ea41d84d57c3a20435145… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/platform.rs M packages/mk-sql/tests/test_ms_sql.rs Log Message: ----------- mk-sql: determine availability of transport using registry Change-Id: I3a0d7aab782a9e4e9aa582808d3eaecb2b0c5eea Commit: 90076c479cec7f8979e78449f84b32ec1936ff54 https://github.com/Checkmk/checkmk/commit/90076c479cec7f8979e78449f84b32ec1… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/instance.rs Log Message: ----------- mk-sql: check the instance name is valid If not report and do nothing. Change-Id: Id02ac8e7794b2a277ee3cd8cab111c1038803373 Commit: 0ba4253039c90848d3f7c4c3e110b161a74ccf5d https://github.com/Checkmk/checkmk/commit/0ba4253039c90848d3f7c4c3e110b161a… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/config/ms_sql.rs M packages/mk-sql/src/ms_sql/instance.rs M packages/mk-sql/src/platform.rs Log Message: ----------- mk-sql: detect non tcp instances Criteria: - integrated connection - disabled TCP Tests: manual for non-TCP case automatic for TCP case The reason: lack of non-TCP DB in infrastructure Change-Id: I64a6da9f5d95c0eb360aa82a07ce2fda6a834615 Compare: https://github.com/Checkmk/checkmk/compare/5f812b70956d...0ba4253039c9 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months, 3 weeks

[Checkmk/checkmk] d7fa2e: 16839 mk-sql ensures instance name is correct

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: d7fa2ed183aebef9e435501fe8b5800650a3eeb7 https://github.com/Checkmk/checkmk/commit/d7fa2ed183aebef9e435501fe8b580065… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: A .werks/16839.md Log Message: ----------- 16839 mk-sql ensures instance name is correct The plugin verifies whether the name of the instance at the specified address matches the name indicated in the config. If the name specified in the config does not match the instance name that responds, the monitoring of this instance will return an error. Example: The config mistakenly indicates that the `SQLEXPRESS` instance is located at `localhost:1433`, whereas the `MSSQLSERVER` instance is actually located at this address. Previously, the instance `MSSQLSERVER` were mistakenly monitored as `SQLEXPRESS`. Starting from this release, this error has been corrected. You need to correct the config if your config contained bad data. Change-Id: I687f018ff753c259b624f966e8d3a7b6d97b44f5 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months, 3 weeks

[Checkmk/checkmk] 6f2998: mk-sql: set local timeout connection to 1 second

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 6f2998a0dc5de1d1127e94cc068036b7b459d62f https://github.com/Checkmk/checkmk/commit/6f2998a0dc5de1d1127e94cc068036b7b… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M packages/mk-sql/src/ms_sql/client.rs M packages/mk-sql/src/ms_sql/instance.rs Log Message: ----------- mk-sql: set local timeout connection to 1 second It is difficult to imagine if timeout is higher. Need to improve performance when port is not available. Change-Id: I65fa4b2c0aaa998eccb147fbb0482f51eea3e381 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months, 3 weeks

[Checkmk/checkmk] 5f812b: Fix github actions

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 5f812b70956da661f7c31855789ca28479117941 https://github.com/Checkmk/checkmk/commit/5f812b70956da661f7c31855789ca2847… Author: Ronny Bruska <ronny.bruska(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M tests/unit/cmk/update_config/plugins/actions/test_global_settings.py Log Message: ----------- Fix github actions Change-Id: If5316a742a2bf08259e96bcbf951630b82f6889a To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months, 3 weeks

[Checkmk/checkmk] 892eee: 16788 FIX notification_rules: encryption type now ...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 892eeed1519f8d6cba230b473c91b44f9fe69cc3 https://github.com/Checkmk/checkmk/commit/892eeed1519f8d6cba230b473c91b44f9… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: A .werks/16788.md M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py M cmk/gui/openapi/endpoints/notification_rules/response_schemas.py Log Message: ----------- 16788 FIX notification_rules: encryption type now an enum When creating a notification rule via the REST-API with the plugin 'asciimail', and configuring the 'enable_sync_smtp field', you could previously set the subfield 'encryption' to any string. Any string is not a valid encryption type. This werk addresses this issue by having this field be an enum of two values which are * ssl_tls * starttls This aligns with the configuration options found in the UI for the same plugin. Change-Id: I6f283e6b55d3365acd6f8011df04dbc8d5fd474b Commit: ff8a206e33e2e7cc7cbc841e069430da99a58095 https://github.com/Checkmk/checkmk/commit/ff8a206e33e2e7cc7cbc841e069430da9… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py M cmk/gui/openapi/endpoints/notification_rules/response_schemas.py M cmk/utils/notify_types.py Log Message: ----------- notification rules: set defaults for the smtp auth fields When auth is enabled, in the UI the fields have defaults. This change aligns the REST-API with the UI in this behaviour. There is no visible change to the user, so I didn't include a werk. I also updated the descriptions in both the request & response schemas. Change-Id: I6da503b35f539e5e63a0cfd79c773c3b7e223e74 Commit: a43cf8b64207b1b866a1ab0457999e67809219c1 https://github.com/Checkmk/checkmk/commit/a43cf8b64207b1b866a1ab0457999e678… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-06-07 (Fri, 07 Jun 2024) Changed paths: A .werks/17014.md M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py M cmk/gui/rest_api_types/notifications_rule_types.py Log Message: ----------- 17014 FIX notification_rules: auth value should be a required field when auth is enabled Previously, when you created a notification rule via the REST-API using the 'mail' plugin, the value of the 'auth' field within the "enable_sync_smtp" schema was not a required field. This is incorrect. If 'auth' is enabled, then the value of 'auth' should be a required field. This werk now addresses this issue. e.g ``` "enable_sync_smtp": { "state": "enabled", "value": { "auth": { "state": "enabled", "value": {"method": "plaintext", "password": "1234", "user": "user_a"}, }, "encryption": "ssl_tls", "port": 25, "smarthosts": ["abc", "def"], }, } ``` Change-Id: I018650850e6d4f1f26e76adb2669ce442e9cfb11 Compare: https://github.com/Checkmk/checkmk/compare/787c9ac4f25e...a43cf8b64207 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

3 months, 3 weeks

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits