From checkmk-commits@lists.checkmk.com Mon May 27 14:36:00 2024
From: Checkmk git commit messages <checkmk-commits@lists.checkmk.com>
To: checkmk-commits@lists.checkmk.com
Subject: [checkmk-commits] [Checkmk/checkmk] 9a4b39: Fix KeyError for nested
 form_specs.DictGroup
Date: Mon, 27 May 2024 07:35:56 -0700
Message-ID: <Checkmk/checkmk/push/refs/heads/master/4a598b-84c77b@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4586577509237958535=="

--===============4586577509237958535==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

  Branch: refs/heads/master
  Home:   https://github.com/Checkmk/checkmk
  Commit: 9a4b399bf25f05f9784bf0d491de94d593581d94
      https://github.com/Checkmk/checkmk/commit/9a4b399bf25f05f9784bf0d491de9=
4d593581d94
  Author: Rebekka Seltmann <rebekka.seltmann(a)checkmk.com>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    A .werks/16797.md
    M cmk/gui/utils/rule_specs/legacy_converter.py
    M tests/unit/cmk/gui/utils/rulespecs/test_legacy_converter.py

  Log Message:
  -----------
  Fix KeyError for nested form_specs.DictGroup

This is only relevant for plugin developers.

In some cases when a `DictGroup` was used inside a FormSpec hierarchy an erro=
r would occur during validation of the relevant rule (e.g. when saving):
```
KeyError: 'DictGroup(title=3D<title>,help_text=3D<help_text>)'
```

Specifically this occurs when there are multiple `Transform`s applied outside=
 the `DictGroup`, e.g. with multiple nested Dictionaries or when a `migrate`/=
`custom_validate` function is defined on the parent FormSPec of the `DictGrou=
p`'s `Dictionary`.

CMK-17513

Change-Id: I2b5cc0840c25cdf0ad2ddb4027422fa5f2a9e81f


  Commit: 84c77b5ec3e823b2435d192b67ead037340f3dac
      https://github.com/Checkmk/checkmk/commit/84c77b5ec3e823b2435d192b67ead=
037340f3dac
  Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    M cmk/plugins/emailchecks/rulesets/active_check_mail_loop.py
    M cmk/plugins/emailchecks/rulesets/active_check_mailboxes.py

  Log Message:
  -----------
  remove validation with plugin params

The plugin expects a  in the BasicAuthParameters,
the ruleset does not have that yet.

Change-Id: I6e415152fa483567d88590c66be7563f55cc5f02


Compare: https://github.com/Checkmk/checkmk/compare/4a598bffbb8b...84c77b5ec3=
e8

To unsubscribe from these emails, change your notification settings at https:=
//github.com/Checkmk/checkmk/settings/notifications


--===============4586577509237958535==--