From noreply@github.com Tue Nov  9 09:02:36 2021
From: Lars <noreply@github.com>
To: checkmk-commits@lists.checkmk.com
Subject: [checkmk-commits] [tribe29/checkmk] 325c34: Migrate mrpe check plugin
Date: Tue, 09 Nov 2021 00:02:33 -0800
Message-ID: <tribe29/checkmk/push/refs/heads/master/180a27-ee1874@github.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6224038407761386132=="

--===============6224038407761386132==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

  Branch: refs/heads/master
  Home:   https://github.com/tribe29/checkmk
  Commit: 325c347643ff9ab360d71449f5439c677343e6e2
      https://github.com/tribe29/checkmk/commit/325c347643ff9ab360d71449f5439=
c677343e6e2
  Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
  Date:   2021-11-09 (Tue, 09 Nov 2021)

  Changed paths:
    M .werks/12908
    R checks/mrpe
    M cmk/base/plugins/agent_based/mrpe.py
    R tests/unit/checks/generictests/datasets/mrpe_old.py
    M tests/unit/checks/test_generic_legacy_conversion.py
    M tests/unit/cmk/base/plugins/agent_based/test_mrpe.py

  Log Message:
  -----------
  Migrate mrpe check plugin

also: The 'OK -' part is not part of the API.
Remove it from the tests.

Change-Id: I9d7941b0ff4071c7fdbe7458713425dca509da1e


  Commit: 2cb84e9af721888aedf043f68692f6dfb7adef73
      https://github.com/tribe29/checkmk/commit/2cb84e9af721888aedf043f68692f=
6dfb7adef73
  Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
  Date:   2021-11-09 (Tue, 09 Nov 2021)

  Changed paths:
    A .werks/13468
    M cmk/base/plugins/agent_based/mrpe.py
    M tests/unit/cmk/base/plugins/agent_based/test_mrpe.py

  Log Message:
  -----------
  13468 mrpe: Do not crash upon invalid metrics

In Checkmk versions prior to 2.0, invalid performance data strings passed by =
the MRPE plugin have been ignored.

In Checkmk 2.0 the parsing would find those invalid strings, and crash upon t=
hem.
This is generally the desired behaviour (see <a href=3Dhttps://docs.checkmk.c=
om/latest/en/devel_check_plugins.html#errors>the documentation</a> for a rati=
onale).

However, since MRPE comprises a lot of different plugins, an all-or-nothing a=
pproach is rather inconvenient.
We now parse everything as good as we can, and issue an <tt>UNKNOWN</tt> stat=
e for the affected service.

Change-Id: I344028bea83efe74c4dc88f05ecac119fa10af9d


  Commit: ee18748e985d9e52a708cc8500067f8909e3df97
      https://github.com/tribe29/checkmk/commit/ee18748e985d9e52a708cc8500067=
f8909e3df97
  Author: Lars Michelsen <lm(a)tribe29.com>
  Date:   2021-11-09 (Tue, 09 Nov 2021)

  Changed paths:
    M cmk/gui/plugins/metrics/graph_templates.py

  Log Message:
  -----------
  Quick fix integration test issues

Will add type hints to uncover these issues
in the future later.

Change-Id: Ia291bd1def9e2be8deb4073c143450c201b0a585


Compare: https://github.com/tribe29/checkmk/compare/180a27660ee0...ee18748e98=
5d

--===============6224038407761386132==--