Checkmk git commits September 2019

checkmk-commits@lists.checkmk.com

1 participants
751 discussions

[tribe29/checkmk] 75ab11: remove failing test

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 75ab11b2176ae0e6ab990cb50804da20ccd39105 https://github.com/tribe29/checkmk/commit/75ab11b2176ae0e6ab990cb50804da20c… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: R tests/unit/checks/generictests/datasets/lnx_quota_regression.py Log Message: ----------- remove failing test Change-Id: I57a375877f4584db41586c775e30e3067b8d1aad Commit: 015631190bea2afac04e596cd49034ed98cbbab3 https://github.com/tribe29/checkmk/commit/015631190bea2afac04e596cd49034ed9… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/8793 M cmk_base/notify.py Log Message: ----------- 8793 FIX notifications crash if non ASCII characters are present in the plugin output For bulk notifications this results in recurring notifications since the corresponding spoolfile was not cleaned up. Non bulk notifications were not sent multiple times. For both normal and bulk notifications no "Final notification result" was produced in the "Host- and Service notifications" view. CMK-2673 Change-Id: I6e567575fc82e9f8d6276f8fefda70d4f1e0ee56 Compare: https://github.com/tribe29/checkmk/compare/09bd29a16952...015631190bea

5 years

[tribe29/checkmk] be2d7a: 8793 FIX notifications crash if non ASCII characte...

by Tom Bärwinkel

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: be2d7a272e69c794ed61cae4afcb30d077312481 https://github.com/tribe29/checkmk/commit/be2d7a272e69c794ed61cae4afcb30d07… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/8793 M cmk_base/notify.py Log Message: ----------- 8793 FIX notifications crash if non ASCII characters are present in the plugin output For bulk notifications this results in recurring notifications since the corresponding spoolfile was not cleaned up. Non bulk notifications were not sent multiple times. For both normal and bulk notifications no "Final notification result" was produced in the "Host- and Service notifications" view. CMK-2673 Change-Id: I6e567575fc82e9f8d6276f8fefda70d4f1e0ee56

5 years

[tribe29/checkmk] f42da1: 10017 FIX mk_docker.py: Add missing diskstat baker...

by Tom Bärwinkel

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: f42da105879e898ca4bee1f8810276493a50f646 https://github.com/tribe29/checkmk/commit/f42da105879e898ca4bee1f8810276493… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/10017 Log Message: ----------- 10017 FIX mk_docker.py: Add missing diskstat bakery option The option to disable the docker_container_diskstat section was missing in version 1.6.0b9. Change-Id: I9f1424a8b3cc236c1f0b8ed3b5d55ba67ea89c9d Commit: 7dc9d370a3d92ce8fc7632d4483c59452f676b55 https://github.com/tribe29/checkmk/commit/7dc9d370a3d92ce8fc7632d4483c59452… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: M locale/de/LC_MESSAGES/multisite.po Log Message: ----------- Some translations CMK-2667 Change-Id: I716266cd57d2ae49eb9e564a150db821fbab8424 Compare: https://github.com/tribe29/checkmk/compare/a6965a67d6e5...7dc9d370a3d9

5 years

[tribe29/checkmk] 09c952: 10041 FIX Reduce apache memory usage + Change chec...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 09c952e62d6d13127fb4d46ee0d4bf419275d489 https://github.com/tribe29/checkmk/commit/09c952e62d6d13127fb4d46ee0d4bf419… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/10041 Log Message: ----------- 10041 FIX Reduce apache memory usage + Change check parameters API We recognized that the 1.6 check parameter (ruleset) plugin mechanism (which was based on classes and using the python abc module) consumed a lot more memory than the previous plugin API. The apache processes were ~50% bigger than in previous Checkmk releases which a too large growth. The problem is that the apache processes are part of a dynamic process pool which can scale from 5 to 64 processes (in the default config). When your apache processes use 130 MB of memory, this means that you would need to have ~8 GB of memory available to be able to handle high usage peaks. In such a situation a single process growth of 50% is relevant and should be avoided if possible. If you have already ported your WATO check parameter plugins to 1.6 you will now have to port it to the new mechanism. The new plugin API for registering check parameters is similar to the 1.5 API, but more explicit to make it easier to understand. For example the 'logins' check parameter declaration looks like this: C:+ from cmk.gui.i18n import _ from cmk.gui.valuespec import ( Integer, Tuple, ) from cmk.gui.plugins.wato import ( CheckParameterRulespecWithoutItem, rulespec_registry, RulespecGroupCheckParametersOperatingSystem, ) def _parameter_valuespec_logins(): return Tuple( help=_("This rule defines upper limits for the number of logins on a system."), elements=[ Integer(title=_("Warning at"), unit=_("users"), default_value=20), Integer(title=_("Critical at"), unit=_("users"), default_value=30) ], ) rulespec_registry.register( CheckParameterRulespecWithoutItem( check_group_name="logins", group=RulespecGroupCheckParametersOperatingSystem, parameter_valuespec=_parameter_valuespec_logins, title=lambda: _("Number of Logins on System"), )) C-: Change-Id: I212c23fc01832d76f6abb4549081b19165a7b62f Commit: 09bd29a1695258e36b2b974b7f46d51a2a29377c https://github.com/tribe29/checkmk/commit/09bd29a1695258e36b2b974b7f46d51a2… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/10042 M cmk_base/config.py Log Message: ----------- 10042 FIX Fix exception caused by autochecks with integers as items The calculation of check parameters during activate changes or checking could cause an exception like "TypeError: expected string or buffer" when a discovery function of a check created services using integers as items instead of strings. Change-Id: I65cd5364e680eab688eaed2dae69db2d71e2be61 Compare: https://github.com/tribe29/checkmk/compare/3f54eed96831...09bd29a16952

5 years

[tribe29/checkmk] a6965a: 10042 FIX Fix exception caused by autochecks with ...

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: a6965a67d6e5fdf1e23610c3de1bfcc4b9ff796f https://github.com/tribe29/checkmk/commit/a6965a67d6e5fdf1e23610c3de1bfcc4b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/10042 M cmk_base/config.py Log Message: ----------- 10042 FIX Fix exception caused by autochecks with integers as items The calculation of check parameters during activate changes or checking could cause an exception like "TypeError: expected string or buffer" when a discovery function of a check created services using integers as items instead of strings. Change-Id: I65cd5364e680eab688eaed2dae69db2d71e2be61

5 years

[tribe29/checkmk] 81dee2: 10056 Windows Agent command line parameter 'reload...

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 81dee27af25b9cf21b7fea11a4bcc945a159a6ce https://github.com/tribe29/checkmk/commit/81dee27af25b9cf21b7fea11a4bcc945a… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/10056 Log Message: ----------- 10056 Windows Agent command line parameter 'reload_config' starts/stops plugins if required Earlier 'reload_config' did not try to run asynchronous plugins. Thus, the parameter was useless for the automatic update of the agent with the Agent Updater plugin. Since now, the Windows Agent starts and stops the asynchronous plugins according to the configuration just loaded with command line parameter 'reload_config'. Change-Id: I464773a4ac035fd0b606d5447c7344f1f136ecb2 Commit: 0c5d9342e57b84e7afcfb90849c28e14a48af915 https://github.com/tribe29/checkmk/commit/0c5d9342e57b84e7afcfb90849c28e14a… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: M agents/wnx/doc/Installation.odt A agents/wnx/doc/Troubleshooting.odt M agents/wnx/doc/Upgrade.odt A agents/wnx/doc/Yaml.odt Log Message: ----------- [CMK-2379] - documentation. - final draft Change-Id: I7335beaa52222079ce9c0eb390b8e89873b50baa Commit: 46f7c9a257513ba079b9226ece481fd38fb8395f https://github.com/tribe29/checkmk/commit/46f7c9a257513ba079b9226ece481fd38… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/10057 Log Message: ----------- 10057 FIX msoffice check works now correctly Previously the Bakery generated the config file for msoffice plugin using wrong name. Additionally, bake agent operation may fail with a crash. Now both errors have been fixed and msoffice check works as intended. Change-Id: I14303b4a77c255255bc38c6c41ef596f65378a23 Commit: b6336dafaff0bc690f86238f1f51c14b50a188c7 https://github.com/tribe29/checkmk/commit/b6336dafaff0bc690f86238f1f51c14b5… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: M agents/wnx/integration/test_section_services.py M agents/wnx/src/engine/cma_core.cpp M agents/wnx/src/engine/cma_core.h M agents/wnx/src/engine/providers/mrpe.cpp M agents/wnx/watest/test-plugin.cpp Log Message: ----------- [FEED-4225] - performance of the plugin processing thread has been increased - polling period is now variable 20ms or 50ms instaed of fixed 250ms - unit tests added, including vbs based - prototype Windows-only function to read as fast as possible from stdio handle added(not used) - code refactoring Change-Id: Ib0aad3c93b2eeccb857adcb1440d4dbaa3cf5bf2 Commit: 0483767a8cc19d9373bf1bd79fc8f332bd741ed0 https://github.com/tribe29/checkmk/commit/0483767a8cc19d9373bf1bd79fc8f332b… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/10058 Log Message: ----------- 10058 FIX Windows Agent: Increased speed of processing data coming from plugins Previously, a plugin that generated large amounts of data could be terminated on the timeout. An example of such plugin is mssql.vbs. Now this problem is solved and the Windows Agent agent fully supports such plugins. Change-Id: I9b1d50cb0918279047a63319fce311a392e262da Commit: 17be63b59417a4ab8b94ddd0ba4eb5ab4a1f17ae https://github.com/tribe29/checkmk/commit/17be63b59417a4ab8b94ddd0ba4eb5ab4… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: M agents/wnx/call_integration_tests.cmd Log Message: ----------- integration script improvement Change-Id: I93a4df9a2d2e20784f73357e1bf466d9755632e2 Commit: 1dc3cda807ae111f03ae7247bc744e61851fb895 https://github.com/tribe29/checkmk/commit/1dc3cda807ae111f03ae7247bc744e618… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: M agents/windows/plugins/ad_replication.bat Log Message: ----------- [SUP-209] - ad replication plugin doesn't query LDAP/AD services anymore - client Windows without AD tools provides empty output - client Windows with AD tools provides <<<ad_replication>>> repadmin_ERROR,-,-,Repadmin can't locate a "home server" or determine our domain because of the following error. Try specifying specific "home server" with /homeserver:[dns name] - AD server provides normal output Change-Id: I7ace73b926ea2bfeb4649f1f70f3923e2e4eb715 Commit: 3f54eed96831f3bdb1fbf6b86d814e7f328f0dae https://github.com/tribe29/checkmk/commit/3f54eed96831f3bdb1fbf6b86d814e7f3… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: M agents/windows/plugins/ad_replication.bat Log Message: ----------- [CMK-2707] [SUP-209] - ad replication plugins doesn't query LDAP/AD services anymore #2 - client Windows without AD tools provides empty output - client Windows with AD tools provides only line <<<ad_replication>>> - AD server provides normal output - important comments added to the script Change-Id: I1c8e993712e3353d8b67d2999b7bf00d40eb7417 Compare: https://github.com/tribe29/checkmk/compare/919f3744b1f9...3f54eed96831

5 years

[tribe29/checkmk] d499bc: Additional rulespec fixes

by Sergey Kipnis

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: d499bc177d6c54a822b793bbf83f4a436590d16f https://github.com/tribe29/checkmk/commit/d499bc177d6c54a822b793bbf83f4a436… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: M cmk/gui/wato/pages/predefined_conditions.py M cmk/gui/watolib/rulespecs.py Log Message: ----------- Additional rulespec fixes * Fix issue in predefined condition config * Fix type declaration: rulesets can also be assigned to top level groups (e.g. user interface) Change-Id: Ie1f03e852a65468db30952f8fe2e71eda49fcbc0 Commit: 4ebbb716e6e7098b8c9b8ab9fa4fd8187d88eebb https://github.com/tribe29/checkmk/commit/4ebbb716e6e7098b8c9b8ab9fa4fd8187… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: M agents/windows/plugins/ad_replication.bat Log Message: ----------- [CMK-2707] [SUP-209] - ad replication plugins doesn't query LDAP/AD services anymore #2 - client Windows without AD tools provides empty output - client Windows with AD tools provides only line <<<ad_replication>>> - AD server provides normal output - important comments added to the script Change-Id: I1c8e993712e3353d8b67d2999b7bf00d40eb7417 Compare: https://github.com/tribe29/checkmk/compare/d409e2c1717a...4ebbb716e6e7

5 years

[tribe29/checkmk] 919f37: 10016 FIX mk_docker.py: crash in diskstat section

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 919f3744b1f962aff555b8789a2fb3af5398c25e https://github.com/tribe29/checkmk/commit/919f3744b1f962aff555b8789a2fb3af5… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/10016 M agents/plugins/mk_docker.py M tests/unit/agents/plugins/test_mk_docker.py Log Message: ----------- 10016 FIX mk_docker.py: crash in diskstat section The plugin in version 1.6.0b9 could not create the diskstat section. Change-Id: Ib509535f06944fc40c0421b1146932ab585848b2

5 years

[tribe29/checkmk] d409e2: 10041 FIX Reduce apache memory usage + Change chec...

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: d409e2c1717a1e675e44e0aa34f613a04e83af5b https://github.com/tribe29/checkmk/commit/d409e2c1717a1e675e44e0aa34f613a04… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/10041 Log Message: ----------- 10041 FIX Reduce apache memory usage + Change check parameters API We recognized that the 1.6 check parameter (ruleset) plugin mechanism (which was based on classes and using the python abc module) consumed a lot more memory than the previous plugin API. The apache processes were ~50% bigger than in previous Checkmk releases which a too large growth. The problem is that the apache processes are part of a dynamic process pool which can scale from 5 to 64 processes (in the default config). When your apache processes use 130 MB of memory, this means that you would need to have ~8 GB of memory available to be able to handle high usage peaks. In such a situation a single process growth of 50% is relevant and should be avoided if possible. If you have already ported your WATO check parameter plugins to 1.6 you will now have to port it to the new mechanism. The new plugin API for registering check parameters is similar to the 1.5 API, but more explicit to make it easier to understand. For example the 'logins' check parameter declaration looks like this: C:+ from cmk.gui.i18n import _ from cmk.gui.valuespec import ( Integer, Tuple, ) from cmk.gui.plugins.wato import ( CheckParameterRulespecWithoutItem, rulespec_registry, RulespecGroupCheckParametersOperatingSystem, ) def _parameter_valuespec_logins(): return Tuple( help=_("This rule defines upper limits for the number of logins on a system."), elements=[ Integer(title=_("Warning at"), unit=_("users"), default_value=20), Integer(title=_("Critical at"), unit=_("users"), default_value=30) ], ) rulespec_registry.register( CheckParameterRulespecWithoutItem( check_group_name="logins", group=RulespecGroupCheckParametersOperatingSystem, parameter_valuespec=_parameter_valuespec_logins, title=lambda: _("Number of Logins on System"), )) C-: Change-Id: I212c23fc01832d76f6abb4549081b19165a7b62f

5 years

[tribe29/checkmk] 544196: 10016 FIX mk_docker.py: crash in diskstat section

by Moritz

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 54419680c45a293ebcc157ae4a9ba2464f768d3d https://github.com/tribe29/checkmk/commit/54419680c45a293ebcc157ae4a9ba2464… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-09-13 (Fri, 13 Sep 2019) Changed paths: A .werks/10016 M agents/plugins/mk_docker.py M tests/unit/agents/plugins/test_mk_docker.py Log Message: ----------- 10016 FIX mk_docker.py: crash in diskstat section The plugin in version 1.6.0b9 could not create the diskstat section. Change-Id: Ib509535f06944fc40c0421b1146932ab585848b2

5 years

← Newer
1
...
38
39
40
41
42
43
44
...
76
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2019